Fix FileHandle/FileIO for VFS

* (Might have accidentally deleted a commit while rebasing...?)

Author: nguyenv

tiledb/cc/vfs.cc

@@ -57,7 +57,9 @@ class FileHandle {
                                       uri.c_str(), mode, &this->_fh));
   }
 
-  void close() { tiledb_vfs_close(_ctx.ptr().get(), this->_fh); }
+  void close() {
+    _ctx.handle_error(tiledb_vfs_close(_ctx.ptr().get(), this->_fh));
+  }
 
   py::bytes read(uint64_t offset, uint64_t nbytes) {
     py::array data = py::array(py::dtype::of<std::byte>(), nbytes);

tiledb/tests/test_libtiledb.py

@@ -3743,7 +3743,7 @@ def test_write_read(self):
         fio.close()
 
         # read from file that does not exist
-        with self.assertRaises(IOError):
+        with self.assertRaises(tiledb.TileDBError):
             vfs.open(self.path("do_not_exist"), "rb")
 
     def test_io(self):

tiledb/vfs.py

@@ -155,19 +155,20 @@ def __init__(self, vfs: VFS, uri: str, mode: str = "rb"):
         }
         if mode not in str_to_vfs_mode:
             raise ValueError(f"invalid mode {mode}")
-        self._mode = mode
 
-        self._fh = lt.FileHandle(
-            self._vfs.ctx(), self._vfs, uri, str_to_vfs_mode[self._mode]
-        )
+        self._mode = mode
         self._offset = 0
         self._nbytes = 0
 
         if self._mode == "rb":
             try:
                 self._nbytes = vfs.file_size(uri)
             except:
-                raise IOError(f"URI {uri} is not a valid file")
+                raise lt.TileDBError(f"URI {uri} is not a valid file")
+
+        self._fh = lt.FileHandle(
+            self._vfs.ctx(), self._vfs, uri, str_to_vfs_mode[self._mode]
+        )
 
     def __len__(self):
         return self._nbytes