Expose overwrite parameter for saving a profile (#2277)

Author: kounelisagis

tiledb/libtiledb/profile.cc

@@ -39,7 +39,12 @@ void init_profile(py::module& m) {
 
         .def("_get_param", &tiledb::Profile::get_param, py::arg("param"))
 
+#if TILEDB_VERSION_MAJOR > 2 || \
+    (TILEDB_VERSION_MAJOR == 2 && TILEDB_VERSION_MINOR >= 30)
+        .def("_save", &tiledb::Profile::save, py::arg("overwrite"))
+#else
         .def("_save", &tiledb::Profile::save)
+#endif
 
         .def_static(
             "_load",

tiledb/profile.py

@@ -74,12 +74,20 @@ def get(self, param: str, raise_keyerror: bool = True):
 
         return val
 
-    def save(self):
+    def save(self, overwrite: bool = False):
         """Saves the profile to storage.
 
+        :param overwrite: Whether to overwrite an existing profile. Defaults to False.
         :raises tiledb.TileDBError:
         """
-        self._save()
+        if lt.version() >= (2, 30):
+            self._save(overwrite)
+        else:
+            if overwrite:
+                raise lt.TileDBError(
+                    "The 'overwrite' parameter is only supported in TileDB 2.30.0 and later"
+                )
+            self._save()
 
     @classmethod
     def load(cls, name: str = None, dir: str = None) -> "Profile":

tiledb/tests/test_profile.py

@@ -101,6 +101,41 @@ def test_profile_save_load_remove(self):
         # remove the profile
         tiledb.Profile.remove("profile2_name", self.path("profile2_dir"))
 
+    @pytest.mark.skipif(
+        lt.version() < (2, 30),
+        reason="Overwrite parameter is only available in TileDB 2.30.0 and later",
+    )
+    def test_profile_save_overwrite(self):
+        token1 = "testing_the_token_1"
+        token2 = "testing_the_token_2"
+        profile_name = "overwrite_test_profile"
+        profile_dir = self.path("overwrite_test_dir")
+
+        # Create and save a profile with token1
+        profile1 = tiledb.Profile(profile_name, profile_dir)
+        profile1["rest.token"] = token1
+        profile1.save()
+
+        # Load it back to verify it was saved
+        loaded_profile1 = tiledb.Profile.load(profile_name, profile_dir)
+        assert loaded_profile1["rest.token"] == token1
+
+        # Create a new profile with the same name and try to save without overwrite
+        profile2 = tiledb.Profile(profile_name, profile_dir)
+        profile2["rest.token"] = token2
+        with pytest.raises(tiledb.TileDBError):
+            profile2.save(overwrite=False)
+
+        # Now save with overwrite=True
+        profile2.save(overwrite=True)
+
+        # Load it back to verify it was overwritten
+        loaded_profile2 = tiledb.Profile.load(profile_name, profile_dir)
+        assert loaded_profile2["rest.token"] == token2
+
+        # Clean up
+        tiledb.Profile.remove(profile_name, profile_dir)
+
 
 class ConfigWithProfileTest(ProfileTestCase):
     def test_config_with_profile(self):