Skip to content

Commit 8e61f3a

Browse files
authored
Set Zstdfilter Default In _get_schema_filters (#1006)
1 parent 07823d0 commit 8e61f3a

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

tiledb/dataframe_.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -182,8 +182,8 @@ def _get_column_infos(df, column_types, varlen_types):
182182

183183
def _get_schema_filters(filters):
184184
if filters is True:
185-
# default case, unspecified: use libtiledb defaults
186-
return None
185+
# default case, use ZstdFilter
186+
return tiledb.FilterList([tiledb.ZstdFilter()])
187187
elif filters is None:
188188
# empty filter list (schema uses zstd by default if unspecified)
189189
return tiledb.FilterList()
@@ -212,7 +212,7 @@ def _get_attrs(names, column_infos, attr_filters):
212212
attrs.append(
213213
tiledb.Attr(
214214
name=name,
215-
filters=filters or [tiledb.ZstdFilter()],
215+
filters=filters,
216216
dtype=column_info.dtype,
217217
nullable=column_info.nullable,
218218
var=column_info.var,
@@ -269,7 +269,7 @@ def dim_for_column(name, values, dtype, tile, full_domain=False, dim_filters=Non
269269
# nb.bytes_ which will force encoding on write
270270
dtype=np.bytes_ if dtype == np.str_ else dtype,
271271
tile=tile,
272-
filters=dim_filters or [tiledb.ZstdFilter()],
272+
filters=dim_filters,
273273
)
274274

275275

@@ -345,7 +345,7 @@ def get_dim_tile(name):
345345
dtype,
346346
tile=get_dim_tile(name),
347347
full_domain=full_domain,
348-
dim_filters=_get_attr_dim_filters(name, filters) or [tiledb.ZstdFilter()],
348+
dim_filters=_get_attr_dim_filters(name, filters),
349349
)
350350
for name, dtype, values in name_dtype_values
351351
]
@@ -539,13 +539,16 @@ def _create_array(uri, df, sparse, full_domain, index_dims, column_infos, tiledb
539539
# create the ArraySchema
540540
with warnings.catch_warnings() as w:
541541
warnings.simplefilter("always")
542+
coord_filter = tiledb_args.get("coords_filters", True)
542543
schema = tiledb.ArraySchema(
543544
sparse=sparse,
544545
domain=tiledb.Domain(*dims),
545546
attrs=attrs,
546547
cell_order=tiledb_args["cell_order"],
547548
tile_order=tiledb_args["tile_order"],
548-
coords_filters=_get_schema_filters(tiledb_args.get("coords_filters", True)),
549+
coords_filters=None
550+
if coord_filter is True
551+
else _get_schema_filters(coord_filter),
549552
offsets_filters=_get_schema_filters(
550553
tiledb_args.get("offsets_filters", True)
551554
),

0 commit comments

Comments
 (0)