Fix fill value for complex attributes

Author: jp-dark

tiledb/attribute.py

@@ -83,6 +83,19 @@ def __init__(
         if fill is not None:
             if self._tiledb_dtype == lt.DataType.STRING_UTF8:
                 self._fill = np.array([fill.encode("utf-8")], dtype="S")
+            elif self.dtype == np.dtype("complex64") or self.dtype == np.dtype(
+                "complex128"
+            ):
+                if hasattr(fill, "dtype") and fill.dtype in {
+                    np.dtype("f4, f4"),
+                    np.dtype("f8, f8"),
+                }:
+                    _fill = fill["f0"] + fill["f1"] * 1j
+                elif hasattr(fill, "__len__") and len(fill) == 2:
+                    _fill = fill[0] + fill[1] * 1j
+                else:
+                    _fill = fill
+                self._fill = np.array(_fill, dtype=self.dtype)
             else:
                 self._fill = np.array([fill], dtype=self.dtype)
 

tiledb/cc/attribute.cc

@@ -37,6 +37,12 @@ py::array get_fill_value(Attribute &attr) {
     value_num = 1;
   }
 
+  // complex type - both cell values fit in a single complex element
+  if (value_type == py::dtype("complex64") ||
+      value_type == py::dtype("complex128")) {
+    value_num = 1;
+  }
+
   return py::array(value_type, value_num, value);
 }
 
@@ -91,4 +97,4 @@ void init_attribute(py::module &m) {
       .def("_dump", [](Attribute &attr) { attr.dump(); });
 }
 
-} // namespace libtiledbcpp
+} // namespace libtiledbcpp

tiledb/tests/test_attribute.py

@@ -88,6 +88,43 @@ def test_ncell_attribute(self):
         with self.assertRaises(TypeError):
             tiledb.Attr("foo", dtype=np.dtype([("", np.float32), ("", np.int32)]))
 
+    def test_complex64_attribute(self):
+        attr = tiledb.Attr("foo", fill=(0 + 1j), dtype=np.dtype("complex64"))
+        assert attr == attr
+        assert attr.fill == attr.fill
+        assert attr.dtype == np.complex64
+        assert attr.ncells == 2
+
+    def test_complex128_attribute(self):
+        dtype = np.dtype([("", np.double), ("", np.double)])
+        attr = tiledb.Attr("foo", fill=(2.0, 2.0), dtype=dtype)
+
+        assert attr == attr
+        assert attr.fill == attr.fill
+        assert attr.dtype == np.complex128
+        assert attr.ncells == 2
+
+    @pytest.mark.parametrize(
+        "fill", [(1.0, 1.0), np.array((1.0, 1.0), dtype=np.dtype("f4, f4"))]
+    )
+    def test_two_cell_float_attribute(self, fill):
+        attr = tiledb.Attr("foo", fill=fill, dtype=np.dtype("f4, f4"))
+
+        assert attr == attr
+        assert attr.dtype == np.complex64
+        assert attr.fill == attr.fill
+        assert attr.ncells == 2
+
+    @pytest.mark.parametrize(
+        "fill", [(1.0, 1.0), np.array((1.0, 1.0), dtype=np.dtype("f8, f8"))]
+    )
+    def test_two_cell_double_attribute(self, fill):
+        attr = tiledb.Attr("foo", fill=fill, dtype=np.dtype("f8, f8"))
+        assert attr == attr
+        assert attr.dtype == np.complex128
+        assert attr.fill == attr.fill
+        assert attr.ncells == 2
+
     def test_ncell_bytes_attribute(self):
         dtype = np.dtype((np.bytes_, 10))
         attr = tiledb.Attr("foo", dtype=dtype)