Add tests asserting equality for dims and domain

Author: jp-dark

tiledb/tests/test_dimension.py

@@ -13,12 +13,14 @@ def test_minimal_dimension(self):
         self.assertEqual(dim.name, "__dim_0", "automatic dimension name is incorrect")
         self.assertEqual(dim.shape, (5,))
         self.assertEqual(dim.tile, 5)
+        self.assertEqual(dim, dim)
 
     def test_dimension(self):
         dim = tiledb.Dim(name="d1", domain=(0, 3), tile=2)
         self.assertEqual(dim.name, "d1")
         self.assertEqual(dim.shape, (4,))
         self.assertEqual(dim.tile, 2)
+        self.assertEqual(dim, dim)
         try:
             assert xml.etree.ElementTree.fromstring(dim._repr_html_()) is not None
         except:
@@ -28,10 +30,12 @@ def test_dimension_filter(self):
         filters = [tiledb.GzipFilter(2)]
         dim = tiledb.Dim(name="df", domain=(0, 2), tile=1, filters=filters)
         self.assertEqual(dim.filters, filters)
+        self.assertEqual(dim, dim)
 
         filter_list = tiledb.FilterList(filters)
         dim = tiledb.Dim(name="df", domain=(0, 2), tile=1, filters=filter_list)
         self.assertEqual(dim.filters, filter_list)
+        self.assertEqual(dim, dim)
 
         with self.assertRaises(TypeError):
             tiledb.Dim(name="df", domain=(0, 2), tile=1, filters=1)
@@ -44,6 +48,7 @@ def test_datetime_dimension(self):
             tile=np.timedelta64(20, "D"),
             dtype=np.datetime64("", "D"),
         )
+        self.assertEqual(dim, dim)
         self.assertEqual(dim.dtype, np.dtype(np.datetime64("", "D")))
         self.assertEqual(dim.tile, np.timedelta64(20, "D"))
         self.assertNotEqual(dim.tile, np.timedelta64(21, "D"))
@@ -69,6 +74,7 @@ def test_datetime_dimension(self):
             tile=20,
             dtype=np.datetime64("", "D"),
         )
+        self.assertEqual(dim, dim)
         self.assertEqual(dim.dtype, np.dtype(np.datetime64("", "D")))
         self.assertEqual(dim.tile, np.timedelta64(20, "D"))
 
@@ -79,6 +85,7 @@ def test_datetime_dimension(self):
             tile=5,
             dtype=np.datetime64("", "Y"),
         )
+        self.assertEqual(dim, dim)
         self.assertEqual(dim.dtype, np.dtype(np.datetime64("", "Y")))
         self.assertEqual(dim.tile, np.timedelta64(5, "Y"))
         self.assertTupleEqual(
@@ -92,6 +99,7 @@ def test_datetime_dimension(self):
             tile=2,
             dtype=np.datetime64("", "D"),
         )
+        self.assertEqual(dim, dim)
         self.assertEqual(dim.tile, np.timedelta64(2, "D"))
         self.assertTupleEqual(
             dim.domain,

tiledb/tests/test_domain.py

@@ -49,6 +49,7 @@ def test_datetime_domain(self):
             dtype=np.datetime64("", "D"),
         )
         dom = tiledb.Domain(dim)
+        self.assertEqual(dom, dom)
         self.assertEqual(dom.dtype, np.datetime64("", "D"))
 
     def test_domain_mixed_names_error(self):
@@ -65,6 +66,7 @@ def test_ascii_domain(self, capfd):
         assert dim.dtype == np.bytes_
 
         dom = tiledb.Domain(dim)
+        self.assertEqual(dom, dom)
         dom.dump()
         assert_captured(capfd, "Type: STRING_ASCII")
 

tiledb/tests/test_libtiledb.py

@@ -80,8 +80,10 @@ def test_tiledbpy_version(self):
 
 class ArrayTest(DiskTestCase):
     def create_array_schema(self):
+        filters = tiledb.FilterList([tiledb.ZstdFilter(level=5)])
         domain = tiledb.Domain(
-            tiledb.Dim(domain=(1, 8), tile=2), tiledb.Dim(domain=(1, 8), tile=2)
+            tiledb.Dim(domain=(1, 8), tile=2, filters=filters),
+            tiledb.Dim(domain=(1, 8), tile=2, filters=filters),
         )
         a1 = tiledb.Attr("val", dtype="f8")
         return tiledb.ArraySchema(domain=domain, attrs=(a1,))