Skip to content

Commit 256eb5e

Browse files
authored
Fix pickle error tiledb.FilterList during BATCH ingestion for Vamana (#349)
1 parent b9fa5fa commit 256eb5e

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

apis/python/src/tiledb/vector_search/ingestion.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -539,6 +539,7 @@ def create_partial_write_array_group(
539539
index_group_uri: str,
540540
vector_type: np.dtype,
541541
dimensions: int,
542+
filters: Any,
542543
create_index_array: bool,
543544
) -> (tiledb.Group, str):
544545
group = tiledb.Group(index_group_uri, "w")
@@ -592,7 +593,7 @@ def create_partial_write_array_group(
592593
ids_attr = tiledb.Attr(
593594
name="values",
594595
dtype=np.dtype(np.uint64),
595-
filters=DEFAULT_ATTR_FILTERS,
596+
filters=filters,
596597
)
597598
ids_schema = tiledb.ArraySchema(
598599
domain=ids_array_dom,
@@ -625,9 +626,7 @@ def create_partial_write_array_group(
625626
dtype=np.dtype(np.int32),
626627
)
627628
parts_array_dom = tiledb.Domain(parts_array_rows_dim, parts_array_cols_dim)
628-
parts_attr = tiledb.Attr(
629-
name="values", dtype=vector_type, filters=DEFAULT_ATTR_FILTERS
630-
)
629+
parts_attr = tiledb.Attr(name="values", dtype=vector_type, filters=filters)
631630
parts_schema = tiledb.ArraySchema(
632631
domain=parts_array_dom,
633632
sparse=False,
@@ -684,6 +683,7 @@ def create_arrays(
684683
index_group_uri=group.uri,
685684
vector_type=vector_type,
686685
dimensions=dimensions,
686+
filters=DEFAULT_ATTR_FILTERS,
687687
create_index_array=True,
688688
)
689689
partial_write_array_index_group = tiledb.Group(
@@ -1523,6 +1523,7 @@ def ingest_vamana(
15231523
import numpy as np
15241524

15251525
import tiledb.cloud
1526+
from tiledb.vector_search.storage_formats import storage_formats
15261527

15271528
logger = setup(config, verbose)
15281529
with tiledb.scope_ctx(ctx_or_config=config):
@@ -1537,6 +1538,7 @@ def ingest_vamana(
15371538
index_group_uri=index_group_uri,
15381539
vector_type=vector_type,
15391540
dimensions=dimensions,
1541+
filters=storage_formats[storage_version]["DEFAULT_ATTR_FILTERS"],
15401542
create_index_array=False,
15411543
)
15421544
partial_write_array_group.close()

0 commit comments

Comments
 (0)