Skip to content

Commit 5497a47

Browse files
author
Nikos Papailiou
committed
Address comments
1 parent 506dc8a commit 5497a47

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

apis/python/src/tiledb/vector_search/ingestion.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ def ingest(
1010
index_type: str,
1111
array_uri: str,
1212
*,
13-
input_vectors: np.array = None,
13+
input_vectors: np.ndarray = None,
1414
source_uri: str = None,
1515
source_type: str = None,
1616
config=None,
@@ -157,7 +157,6 @@ def autodetect_source_type(source_uri: str) -> str:
157157
else:
158158
return "TILEDB_ARRAY"
159159

160-
161160
def read_source_metadata(
162161
source_uri: str, source_type: str = None
163162
) -> Tuple[int, int, np.dtype]:
@@ -210,7 +209,7 @@ def read_source_metadata(
210209

211210
def write_input_vectors(
212211
group: tiledb.Group,
213-
input_vectors: np.array,
212+
input_vectors: np.ndarray,
214213
size: int,
215214
dimensions: int,
216215
vector_type: np.dtype,
@@ -567,7 +566,7 @@ def read_input_vectors(
567566
config: Optional[Mapping[str, Any]] = None,
568567
verbose: bool = False,
569568
trace_id: Optional[str] = None,
570-
) -> np.array:
569+
) -> np.ndarray:
571570
logger = setup(config, verbose)
572571
logger.debug(
573572
"Reading input vectors start_pos: %i, end_pos: %i", start_pos, end_pos
@@ -735,7 +734,7 @@ def init_centroids(
735734
config: Optional[Mapping[str, Any]] = None,
736735
verbose: bool = False,
737736
trace_id: Optional[str] = None,
738-
) -> np.array:
737+
) -> np.ndarray:
739738
logger = setup(config, verbose)
740739
logger.debug(
741740
"Initialising centroids by reading the first vectors in the source data."
@@ -754,7 +753,7 @@ def init_centroids(
754753
)
755754

756755
def assign_points_and_partial_new_centroids(
757-
centroids: np.array,
756+
centroids: np.ndarray,
758757
source_uri: str,
759758
source_type: str,
760759
vector_type: np.dtype,
@@ -925,7 +924,7 @@ def ingest_flat(
925924
target.close()
926925

927926
def write_centroids(
928-
centroids: np.array,
927+
centroids: np.ndarray,
929928
array_uri: str,
930929
partitions: int,
931930
dimensions: int,

apis/python/test/test_ingestion.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import pytest
99

10-
MINIMUM_ACCURACY = 0.9
10+
MINIMUM_ACCURACY = 0.85
1111

1212

1313
@pytest.mark.parametrize("query_type", ["heap", "nth"])

0 commit comments

Comments
 (0)