Skip to content

Commit 913a73f

Browse files
authored
Fix flaky unit tests (#288)
1 parent b0e733d commit 913a73f

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

apis/python/test/test_type_erased_module.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ def test_inplace_build_infinite_query_IndexIVFFlat():
272272
if nprobe == 8:
273273
assert recall > 0.925
274274
if nprobe == 32:
275-
assert recall == 1.0
275+
assert recall >= 0.999
276276

277277

278278
def test_read_index_and_infinite_query():

src/include/test/unit_api_ivf_flat_index.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ TEST_CASE(
201201
auto nt = num_vectors(t);
202202
auto recall = ((double)intersections) / ((double)nt * k_nn);
203203
if (nprobe == 32) {
204-
CHECK(std::abs(recall - 1.0) <= 1e-3);
204+
CHECK(recall >= 0.999);
205205
} else if (nprobe == 8) {
206206
CHECK(recall > 0.925);
207207
}
@@ -259,7 +259,7 @@ TEST_CASE(
259259
CHECK(nt == nv);
260260
auto recall = ((double)intersections_a) / ((double)nt * k_nn);
261261
if (nprobe == 32) {
262-
CHECK(recall == 1.0);
262+
CHECK(recall >= 0.999);
263263
} else if (nprobe == 8) {
264264
CHECK(recall > 0.925);
265265
}
@@ -305,7 +305,7 @@ TEST_CASE(
305305
CHECK(nt == nv);
306306
auto recall = ((double)intersections_a) / ((double)nt * k_nn);
307307
if (nprobe == 32) {
308-
CHECK(std::abs(recall - 1.0) <= 1e-3);
308+
CHECK(recall >= 0.999);
309309
} else if (nprobe == 8) {
310310
CHECK(recall > 0.925);
311311
}

src/include/test/unit_logging.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ TEST_CASE("logging: ordering", "[logging]") {
170170

171171
std::cout << f_t << " " << g_t << " " << h_t << " " << i_t << std::endl;
172172

173-
CHECK((i_t > 799 && i_t < 880));
173+
CHECK((i_t > 799 && i_t < 890));
174174
CHECK((h_t > 499 && h_t < 560));
175175
CHECK((g_t > 499 && g_t < 560));
176176
CHECK((f_t > 499 && f_t < 560));

0 commit comments

Comments
 (0)