Skip to content

Commit a88d0a6

Browse files
Windows support. (#103)
* Add flags for MSVC. * Remove an unused Unix header. * Fix an MSVC compiler error. * Fix another MSVC compile error.
1 parent 923d014 commit a88d0a6

File tree

4 files changed

+8
-3
lines changed

4 files changed

+8
-3
lines changed

apis/python/src/tiledb/vector_search/module.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ PYBIND11_MAKE_OPAQUE(std::vector<uint32_t>);
2323
PYBIND11_MAKE_OPAQUE(std::vector<uint64_t>);
2424
PYBIND11_MAKE_OPAQUE(std::vector<float>);
2525
PYBIND11_MAKE_OPAQUE(std::vector<double>);
26-
#if !defined(__GNUC__)
26+
#if !(defined(__GNUC__) || defined(_MSC_VER))
2727
PYBIND11_MAKE_OPAQUE(std::vector<size_t>);
2828
#endif
2929

src/CMakeLists.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,12 @@ if (CMAKE_OSX_ARCHITECTURES STREQUAL arm64 OR CMAKE_SYSTEM_PROCESSOR MATCHES "^a
108108
# set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-Ofast -g -DNDEBUG" CACHE STRING "" FORCE)
109109
set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-Ofast -g -UNDEBUG" CACHE STRING "" FORCE)
110110
set(CMAKE_CXX_FLAGS_MINSIZEREL "-Os -DNDEBUG " CACHE STRING "" FORCE)
111+
elseif(MSVC)
112+
set(CMAKE_CXX_FLAGS_DEBUG "/Od /Zi /EHsc /RTC1" CACHE STRING "" FORCE)
113+
set(CMAKE_CXX_FLAGS_RELEASE "/O2" CACHE STRING "" FORCE)
114+
set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "/O2 /Zi" CACHE STRING "" FORCE)
115+
set(CMAKE_CXX_FLAGS_MINSIZEREL "/O1" CACHE STRING "" FORCE)
116+
add_compile_definitions("$<$<NOT:$<CONFIG:Debug>>:NDEBUG>")
111117
else()
112118
set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g -fno-elide-constructors ${FCONCEPTS_DIAGNOSTICS_DEPTH} " CACHE STRING "" FORCE)
113119
set(CMAKE_CXX_FLAGS_RELEASE "-Ofast -march=native -DNDEBUG " CACHE STRING "" FORCE)

src/include/defs.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ bool validate_top_k(TK& top_k, G& g) {
314314
return false;
315315
}
316316
std::cout << "Query " << qno << " is incorrect" << std::endl;
317-
for (size_t i = 0; i < std::min(k, 10UL); ++i) {
317+
for (size_t i = 0; i < std::min(k, static_cast<size_t>(10UL)); ++i) {
318318
std::cout << " (" << top_k(i, qno) << " " << g(i, qno) << ")";
319319
}
320320
std::cout << std::endl;

src/include/stats.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
#ifndef TDB_STATS_H
4040
#define TDB_STATS_H
4141

42-
#include <unistd.h>
4342
#include <fstream>
4443
#include <iomanip>
4544
#include <iostream>

0 commit comments

Comments
 (0)