Fix small C++ warnings around type conversions (#520)

Author: jparismorgan

documentation/Building.md

@@ -13,7 +13,7 @@ cmake --build ./src/build -j3
 
 Then you can run the tests:
 
-```
+```bash
 cmake --build ./src/build --target check
 ```
 

src/include/index/flat_pq_index.h

@@ -200,8 +200,6 @@ class flat_pq_index {
       auto sub_begin = subspace * dimensions_ / num_subspaces_;
       auto sub_end = (subspace + 1) * dimensions_ / num_subspaces_;
 
-      auto local_sub_distance = SubDistance{sub_begin, sub_end};
-
       sub_kmeans_random_init(training_set, centroids_, sub_begin, sub_end);
       size_t iters;
       double conv;

src/include/test/unit_algorithm.cc

@@ -192,7 +192,7 @@ TEST_CASE("range_for_each", "[algorithm]") {
 
   // Test with both a vector (b/c it's simple) and matrix (b/c it's what we use
   // in practice).
-  std::vector<int> thread_used(num_vectors, 0);
+  std::vector<size_t> thread_used(num_vectors, 0);
   auto thread_used_matrix = ColMajorMatrix<float>(k, num_vectors);
 
   for (size_t num_threads = 1;
@@ -203,7 +203,7 @@ TEST_CASE("range_for_each", "[algorithm]") {
         queries,
         [&](auto&& vector, auto thread_index, auto index) {
           thread_used[index] = thread_index;
-          for (int j = 0; j < k; ++j) {
+          for (size_t j = 0; j < k; ++j) {
             thread_used_matrix[index][j] = thread_index;
           }
         });

src/include/test/unit_api_feature_vector_array.cc

@@ -246,8 +246,8 @@ TEST_CASE("feature vector array with IDs open", "[api]") {
 }
 
 TEST_CASE("MatrixWithIds constructors and destructors", "[api]") {
-  auto rows = 3;
-  auto cols = 7;
+  uint64_t rows = 3;
+  uint64_t cols = 7;
 
   SECTION("copy constructor") {
     using DataType = int;

src/include/test/unit_ivf_pq_group.cc

@@ -113,8 +113,8 @@ TEST_CASE("write constructor - create and read", "[ivf_pq_group]") {
 
   {
     uint64_t dimensions = 10;
-    auto num_clusters = 11;
-    auto num_subspaces = 12;
+    uint32_t num_clusters = 11;
+    uint32_t num_subspaces = 12;
     ivf_pq_group x = ivf_pq_group<dummy_index>(
         ctx,
         tmp_uri,

src/include/test/unit_ivf_qv.cc

@@ -591,10 +591,10 @@ TEST_CASE("indices", "[ivf qv]") {
       (std::filesystem::temp_directory_path() / "ids").string();
 
   // Create the partitioned_matrix.
-  int num_vectors = GENERATE(37, 99, 377);
+  size_t num_vectors = GENERATE(37, 99, 377);
   uint64_t dimensions = 3;
-  int num_parts = num_vectors;
-  int num_queries = GENERATE(1, 9, 38);
+  size_t num_parts = num_vectors;
+  size_t num_queries = GENERATE(1, 9, 38);
   std::vector<part_index_type> indices;
   {
     auto training_set = ColMajorMatrix<feature_type>(dimensions, num_vectors);

src/include/test/unit_matrix_with_ids.cc

@@ -202,7 +202,7 @@ TEMPLATE_TEST_CASE(
     stdx::layout_left) {
   std::vector<MatrixWithIds<float, float, TestType>> v;
 
-  auto numIds = 3;
+  size_t numIds = 3;
   auto A = MatrixWithIds<float, float, TestType>{
       {{8, 6, 7}, {5, 3, 0}, {9, 5, 0}}, {0, 1, 2}};
   auto aptr = A.data();

src/include/test/unit_partition.cc

@@ -81,8 +81,8 @@ TEST_CASE("partition_ivf_index", "[partition]") {
   // auto partition_ivf_index(
   //      auto&& centroids, auto&& query, size_t nprobe, size_t nthreads)
 
-  auto nprobe = GENERATE(1, 2, 3);
-  auto nthreads = GENERATE(3);
+  size_t nprobe = GENERATE(1, 2, 3);
+  size_t nthreads = GENERATE(3);
 
   auto&& [active_partitions, active_queries] =
       detail::ivf::partition_ivf_flat_index<uint32_t>(

src/include/test/unit_seeder.cc

@@ -124,6 +124,7 @@ TEST_CASE("Singleton behavior", "[seeder]") {
 
   // Ensure they have the same seed value
   auto seed = seeder1.seed();
+  CHECK(seed.has_value());
   CHECK_THROWS_WITH(
       seeder2.seed(),
       Catch::Matchers::ContainsSubstring("Seed can only be used once"));

src/include/test/unit_tdb_matrix_multi_range.cc

@@ -191,7 +191,6 @@ TEST_CASE("limit column_indices", "[tdb_matrix_multi_range]") {
   using T = float;
   using I = size_t;
   using LayoutPolicy = stdx::layout_left;
-  using IdsType = uint8_t;
 
   std::string tmp_matrix_uri =
       (std::filesystem::temp_directory_path() / "tmp_tdb_matrix").string();