fix(ingestion): Pad sparse matrices to correct dimensions #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug in `ingestion.py` where sparse matrices with null entries at the end were being read with incorrect dimensions. Previously, the `read_input_vectors` function would convert a sparse matrix to a dense matrix without accounting for trailing null columns. This could lead to a mismatch in dimensions later in the code, as a `10x100` sparse matrix might be read as a `10x90` dense matrix if its last 10 columns were empty. The fix adds a check to ensure the matrix is padded with zeros to the expected dimensions, preventing the dimension mismatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in
ingestion.pywhere sparse matrices with null entries at the end were being read with incorrect dimensions.Previously, the
read_input_vectorsfunction would convert a sparse matrix to a dense matrix without accounting for trailing null columns. This could lead to a mismatch in dimensions later in the code.For example, a sparse array whose schema specified a shape of
10x100might be read as a10x90dense matrix if its last 10 columns were empty.The fix adds a check to ensure the matrix is padded with zeros to the expected dimensions, preventing the dimension mismatch.