Fix crash in current domain triggered by incorrect function selection. (#5199)

Fix crash in current domain triggered by incorrect function selection
for range() in the cpp api
`range<std::string>` now selects the correct specialization.

[[sc-51234]](https://app.shortcut.com/tiledb-inc/story/51234)

---
TYPE: NO_HISTORY
DESC: Fix crash in current domain triggered by incorrect function
selection.

---------

Co-authored-by: Luc Rancourt <[email protected]>

Author: robertbindar

test/src/test-cppapi-current-domain.cc

@@ -118,10 +118,10 @@ TEST_CASE_METHOD(
   ndrect.set_range(1, std::string("b"), std::string("db"));
 
   // Get and check ranges
-  std::array<std::string, 2> range = ndrect.range(0);
+  std::array<std::string, 2> range = ndrect.range<std::string>(0);
   CHECK(range[0] == "a");
   CHECK(range[1] == "c");
-  range = ndrect.range(1);
+  range = ndrect.range<std::string>(1);
   CHECK(range[0] == "b");
   CHECK(range[1] == "db");
 
@@ -134,10 +134,10 @@ TEST_CASE_METHOD(
   auto rect = current_domain.ndrectangle();
 
   // Get and check ranges
-  range = ndrect.range(0);
+  range = ndrect.range<std::string>(0);
   CHECK(range[0] == "a");
   CHECK(range[1] == "c");
-  range = ndrect.range(1);
+  range = ndrect.range<std::string>(1);
   CHECK(range[0] == "b");
   CHECK(range[1] == "db");
 }

tiledb/sm/cpp_api/ndrectangle.h

@@ -225,47 +225,6 @@ class NDRectangle {
     return *this;
   }
 
-  /**
-   * Retrieves a range for a given variable length string dimension index and
-   * range id.
-   *
-   * @param dim_idx The dimension index.
-   * @param range_idx The range index.
-   * @return A pair of the form (start, end).
-   */
-  std::array<std::string, 2> range(unsigned dim_idx) {
-    auto& ctx = ctx_.get();
-    tiledb_range_t range;
-
-    ctx.handle_error(tiledb_ndrectangle_get_range(
-        ctx.ptr().get(), ndrect_.get(), dim_idx, &range));
-
-    std::string start_str(static_cast<const char*>(range.min), range.min_size);
-    std::string end_str(static_cast<const char*>(range.max), range.max_size);
-
-    return {std::move(start_str), std::move(end_str)};
-  }
-
-  /**
-   * Retrieves a range for a given variable length string dimension index and
-   * range id.
-   *
-   * @param dim_name The dimension name.
-   * @param range_idx The range index.
-   * @return A pair of the form (start, end).
-   */
-  std::array<std::string, 2> range(const std::string& dim_name) {
-    auto& ctx = ctx_.get();
-    tiledb_range_t range;
-    ctx.handle_error(tiledb_ndrectangle_get_range_from_name(
-        ctx.ptr().get(), ndrect_.get(), dim_name.c_str(), &range));
-
-    std::string start_str(static_cast<const char*>(range.min), range.min_size);
-    std::string end_str(static_cast<const char*>(range.max), range.max_size);
-
-    return {std::move(start_str), std::move(end_str)};
-  }
-
   /**
    * Retrieves a range for a given dimension name. The template datatype must be
    * the same as that of the underlying array.
@@ -326,6 +285,50 @@ class NDRectangle {
   impl::Deleter deleter_;
 };
 
+/**
+ * Retrieves a range for a given variable length string dimension index and
+ * range id.
+ *
+ * @param dim_name The dimension name.
+ * @param range_idx The range index.
+ * @return A pair of the form (start, end).
+ */
+template <>
+inline std::array<std::string, 2> NDRectangle::range<std::string>(
+    const std::string& dim_name) {
+  auto& ctx = ctx_.get();
+  tiledb_range_t range;
+  ctx.handle_error(tiledb_ndrectangle_get_range_from_name(
+      ctx.ptr().get(), ndrect_.get(), dim_name.c_str(), &range));
+
+  std::string start_str(static_cast<const char*>(range.min), range.min_size);
+  std::string end_str(static_cast<const char*>(range.max), range.max_size);
+
+  return {std::move(start_str), std::move(end_str)};
+}
+
+/**
+ * Retrieves a range for a given variable length string dimension index and
+ * range id.
+ *
+ * @param dim_idx The dimension index.
+ * @param range_idx The range index.
+ * @return A pair of the form (start, end).
+ */
+template <>
+inline std::array<std::string, 2> NDRectangle::range(unsigned dim_idx) {
+  auto& ctx = ctx_.get();
+  tiledb_range_t range;
+
+  ctx.handle_error(tiledb_ndrectangle_get_range(
+      ctx.ptr().get(), ndrect_.get(), dim_idx, &range));
+
+  std::string start_str(static_cast<const char*>(range.min), range.min_size);
+  std::string end_str(static_cast<const char*>(range.max), range.max_size);
+
+  return {std::move(start_str), std::move(end_str)};
+}
+
 }  // namespace tiledb
 
 #endif  // TILEDB_CPP_API_NDRECTANGLE_H