Keep opened array resources alive until query ends. (#4601)

This change moves all the opened array resources used in strategies to a
class so that they can be acquired as a shared pointer when the strategy
begins and kept alive until the strategy is done.

[sc-38872]

---
TYPE: IMPROVEMENT
DESC: Keep opened array resources alive until query ends.

---------

Co-authored-by: Paul J. Davis <[email protected]>

Author: KiterLuc

test/src/unit-Reader.cc

@@ -165,15 +165,16 @@ TEST_CASE_METHOD(
   DefaultChannelAggregates default_channel_aggregates;
   auto params = StrategyParams(
       context.storage_manager(),
-      &array,
+      array.opened_array(),
       config,
       buffers,
       aggregate_buffers,
       subarray,
       Layout::ROW_MAJOR,
       condition,
       default_channel_aggregates,
-      false);
+      false,
+      array.memory_tracker());
   Reader reader(&g_helper_stats, g_helper_logger(), params);
   unsigned dim_num = 2;
   auto size = 2 * sizeof(int32_t);

test/src/unit-capi-array.cc

@@ -2337,7 +2337,7 @@ TEST_CASE_METHOD(
 
   // Check the retrieved non empty domain
   auto non_empty_domain = new_array->array_->loaded_non_empty_domain();
-  CHECK(non_empty_domain->empty() == false);
+  CHECK(non_empty_domain.empty() == false);
 
   // Check the retrieved metadata
   Datatype type;

test/src/unit-capi-fragment_info.cc

@@ -1279,6 +1279,8 @@ TEST_CASE(
   rc = tiledb_array_consolidate(ctx, array_name.c_str(), config);
   CHECK(rc == TILEDB_OK);
 
+  tiledb_config_free(&config);
+
   // Load fragment info
   rc = tiledb_fragment_info_load(ctx, fragment_info);
   CHECK(rc == TILEDB_OK);

test/src/unit-cppapi-array.cc

@@ -2088,3 +2088,52 @@ TEST_CASE(
   vfs.remove_dir(get_commit_dir(array_read.uri()));
   vfs.remove_dir(array_read.uri() + "/__schema");
 }
+
+TEST_CASE(
+    "C++ API: Close array with running query", "[cppapi][close-before-read]") {
+  const std::string array_name = "cpp_unit_array";
+  Context ctx;
+  VFS vfs(ctx);
+
+  if (vfs.is_dir(array_name))
+    vfs.remove_dir(array_name);
+
+  // Create
+  Domain domain(ctx);
+  domain.add_dimension(Dimension::create<int>(ctx, "rows", {{0, 3}}, 4))
+      .add_dimension(Dimension::create<int>(ctx, "cols", {{0, 3}}, 4));
+  ArraySchema schema(ctx, TILEDB_DENSE);
+  schema.set_domain(domain).set_order({{TILEDB_ROW_MAJOR, TILEDB_ROW_MAJOR}});
+  schema.add_attribute(Attribute::create<int>(ctx, "a"));
+  Array::create(array_name, schema);
+
+  // Write
+  std::vector<int> data_w = {
+      1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16};
+  Array array_w(ctx, array_name, TILEDB_WRITE);
+  Query query_w(ctx, array_w);
+  query_w.set_subarray(Subarray(ctx, array_w).set_subarray({0, 3, 0, 3}))
+      .set_layout(TILEDB_ROW_MAJOR)
+      .set_data_buffer("a", data_w);
+  query_w.submit();
+  array_w.close();
+
+  // Open for read.
+  Array array(ctx, array_name, TILEDB_READ);
+  std::vector<int> subarray_read = {0, 3, 0, 3};
+  std::vector<int> a_read(16);
+
+  Query query(ctx, array);
+  query.set_subarray(subarray_read)
+      .set_layout(TILEDB_ROW_MAJOR)
+      .set_data_buffer("a", a_read);
+  query.submit_async();
+  array.close();
+
+  uint64_t i = 0;
+  while (query.query_status() != Query::Status::COMPLETE) {
+    i++;
+  }
+
+  CHECK(i > 0);
+}

test/src/unit-cppapi-deletes.cc

@@ -458,7 +458,7 @@ void DeletesFx::check_delete_conditions(
 
   // Load delete conditions.
   auto&& [st, delete_conditions, update_values] =
-      sm_->load_delete_and_update_conditions(*array_ptr);
+      sm_->load_delete_and_update_conditions(*(array_ptr->opened_array()));
   REQUIRE(st.ok());
   REQUIRE(delete_conditions->size() == qcs.size());
 

test/src/unit-cppapi-subarray.cc

@@ -415,32 +415,6 @@ TEST_CASE("C++ API: Test subarray (dense)", "[cppapi][dense][subarray]") {
     // default expected to err.
     REQUIRE_THROWS(subarray.set_subarray({1, 4, -1, 3}));
     tiledb::Config config;
-    // The config option should be ignored but we set anyway.
-    config.set("sm.read_range_oob", "error");
-    subarray.set_config(config);
-    REQUIRE_THROWS(subarray.set_subarray({1, 4, -1, 3}));
-  }
-
-  SECTION("- set_subarray Write ranges oob warn - Subarray-query") {
-    tiledb::Array array(ctx, array_name, TILEDB_WRITE);
-    tiledb::Query query(ctx, array);
-    // default (dense) WRITE should always err/throw on oob
-    REQUIRE_THROWS(query.set_subarray({1, 4, -1, 3}));
-    tiledb::Config config;
-    config.set("sm.read_range_oob", "warn");
-    query.set_config(config);
-    // (dense) WRITE should ignore sm.read_range_oob config option
-    // and err/throw on oob
-    REQUIRE_THROWS(query.set_subarray({1, 4, -1, 3}));
-  }
-
-  SECTION("- set_subarray Write ranges oob warn - Subarray-cppapi") {
-    tiledb::Array array(ctx, array_name, TILEDB_WRITE);
-    tiledb::Subarray subarray(ctx, array);
-    REQUIRE_THROWS(subarray.set_subarray({1, 4, -1, 3}));
-    tiledb::Config config;
-    config.set("sm.read_range_oob", "warn");
-    subarray.set_config(config);
     REQUIRE_THROWS(subarray.set_subarray({1, 4, -1, 3}));
   }
 

test/src/unit-cppapi-update-queries.cc

@@ -203,7 +203,7 @@ void UpdatesFx::check_update_conditions(
 
   // Load delete conditions.
   auto&& [st, conditions, update_values] =
-      sm_->load_delete_and_update_conditions(*array_ptr);
+      sm_->load_delete_and_update_conditions(*(array_ptr->opened_array()));
   REQUIRE(st.ok());
   REQUIRE(conditions->size() == qcs.size());