Throw exception if not using array open v3.

Author: shaunrd0

test/src/unit-cppapi-enumerations.cc

@@ -349,6 +349,16 @@ TEST_CASE_METHOD(
       false);
   std::string schema_name_1 = schema.ptr()->array_schema()->name();
 
+  // If not using array open v3 just test that the correct exception is thrown
+  if (!array.ptr()->array()->use_refactored_array_open()) {
+    CHECK_THROWS_WITH(
+        ArrayExperimental::load_enumerations_all_schemas(ctx_, array),
+        Catch::Matchers::ContainsSubstring(
+            "The array must be opened using "
+            "`rest.use_refactored_array_open=true`"));
+    return;
+  }
+
   // Evolve once to add an enumeration.
   ArraySchemaEvolution ase(ctx_);
   std::vector<std::string> var_values{"one", "two", "three"};
@@ -359,7 +369,7 @@ TEST_CASE_METHOD(
   ase.add_attribute(attr4);
   ase.array_evolve(uri_);
   array.reopen();
-  ArrayExperimental::load_enumerations_all_schemas(ctx_, array);
+  CHECK_NOTHROW(ArrayExperimental::load_enumerations_all_schemas(ctx_, array));
   auto all_schemas = array.ptr()->array()->array_schemas_all();
   schema = array.load_schema(ctx_, uri_);
   std::string schema_name_2 = schema.ptr()->array_schema()->name();

test/src/unit-enumerations.cc

@@ -1128,6 +1128,16 @@ TEST_CASE_METHOD(
   REQUIRE(schema->is_enumeration_loaded("test_enmr") == false);
   std::string schema_name_1 = schema->name();
 
+  // If not using array open v3 just test that the correct exception is thrown
+  if (!array->use_refactored_array_open()) {
+    CHECK_THROWS_WITH(
+        array->load_all_enumerations(true),
+        Catch::Matchers::ContainsSubstring(
+            "The array must be opened using "
+            "`rest.use_refactored_array_open=true`"));
+    return;
+  }
+
   // Evolve once to add an enumeration.
   auto ase = make_shared<ArraySchemaEvolution>(HERE(), memory_tracker_);
   std::vector<std::string> var_values{"one", "two", "three"};

tiledb/api/c_api/array/array_api.cc

@@ -666,6 +666,14 @@ capi_return_t tiledb_array_load_all_enumerations(const tiledb_array_t* array) {
 capi_return_t tiledb_array_load_enumerations_all_schemas(
     const tiledb_array_t* array) {
   ensure_array_is_valid(array);
+  // Array::array_schemas_all_ is only initialized using array open V3, so we
+  // won't have schemas to store the loaded enumerations unless array open V3 is
+  // used.
+  if (!array->array()->use_refactored_array_open()) {
+    throw CAPIException(
+        "Unable to load enumerations for all array schemas; The array must be "
+        "opened using `rest.use_refactored_array_open=true");
+  }
   array->load_all_enumerations(true);
   return TILEDB_OK;
 }

tiledb/api/c_api/array/array_api_experimental.h

@@ -108,6 +108,9 @@ TILEDB_EXPORT capi_return_t tiledb_array_load_all_enumerations(
 /**
  * Load all enumerations for all schemas in the array.
  *
+ * This method requires the array to be opened with the config option
+ * `rest.use_refactored_array_open=true`.
+ *
  * **Example:**
  *
  * @code{.c}

tiledb/sm/array/array.cc

@@ -946,19 +946,13 @@ void Array::load_all_enumerations(bool all_schemas) {
   }
   // Load all enumerations, discarding the returned list of loaded enumerations.
   if (all_schemas) {
-    // Since array open v1 does not initialize array_schemas_all, we need to
-    // either serialize the full schemas with LoadEnumerationsResponse, or
-    // reopen the array using array open v2 (only if the config is set to use
-    // v1) so that we can store the enumerations from the response in the
-    // correct schemas using the schema names.
-
-    // For now, reopen the array if it's found to be using array open v1.
-    // Once we update to use post_array_schema_from_rest we will always have
-    // array_schemas_all initialized and this could go away.
+    // Unless we are using array open V3, Array::array_schemas_all_ will not be
+    // initialized. We throw an exception since this is required to store the
+    // loaded enumerations.
     if (!use_refactored_array_open()) {
-      throw_if_not_ok(config_.set("rest.use_refactored_array_open", "true"));
-      throw_if_not_ok(reopen());
-      throw_if_not_ok(config_.set("rest.use_refactored_array_open", "false"));
+      throw ArrayException(
+          "Unable to load enumerations for all array schemas; The array must "
+          "be opened using `rest.use_refactored_array_open=true`");
     }
 
     get_enumerations_all_schemas();