Update to clang-format 17. (#4675)

[SC-39200](https://app.shortcut.com/tiledb-inc/story/39200/make-sure-that-clang-format-is-the-same-across-os-jobs)

There are no formatting changes.

---
TYPE: NO_HISTORY

Author: teo-tsirpanis

cmake/Modules/FindClangTools.cmake

@@ -52,7 +52,7 @@ endif()
 
 find_program(CLANG_FORMAT_BIN
   NAMES
-  clang-format-16
+  clang-format-17
   clang-format
   PATHS ${ClangTools_PATH} $ENV{CLANG_TOOLS_PATH} /usr/local/bin /usr/bin
         NO_DEFAULT_PATH

cmake/Modules/Format.cmake

@@ -32,7 +32,7 @@ set(SCRIPTS_DIR "${CMAKE_CURRENT_SOURCE_DIR}/scripts")
 
 find_package(ClangTools)
 if (NOT ${CLANG_FORMAT_FOUND})
-  find_program(CLANG_FORMAT_BIN NAMES clang-format-16)
+  find_program(CLANG_FORMAT_BIN NAMES clang-format-17)
   if(CLANG_FORMAT_BIN)
     set(CLANG_FORMAT_FOUND TRUE)
   endif()

scripts/ci/check_formatting_linux.sh

@@ -35,4 +35,4 @@ sudo ./scripts/install-clangformat.sh
 src=$GITHUB_WORKSPACE
 cd $src
 
-$src/scripts/run-clang-format.sh $src clang-format-16 0
+$src/scripts/run-clang-format.sh $src clang-format-17 0

scripts/install-clangformat.sh

@@ -29,9 +29,9 @@ die() {
 }
 
 install_apt_pkg() {
-  wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add -
-  add-apt-repository 'deb http://apt.llvm.org/focal/ llvm-toolchain-focal-16 main' &&
-  apt-get update -qq && apt-get install -qq -y clang-format-16
+  wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key > /etc/apt/trusted.gpg.d/apt.llvm.org.asc
+  add-apt-repository 'deb http://apt.llvm.org/focal/ llvm-toolchain-focal-17 main' &&
+  apt-get update -qq && apt-get install -qq -y clang-format-17
 }
 
 install_brew_pkg() {