Use new AWS SDK client constructors. (#5232)

[SC-51986](https://app.shortcut.com/tiledb-inc/story/51986/stop-using-deprecated-s3client-constructors)

AWS SDK client constructors that accept a generic `ClientConfig` are
[deprecated](https://github.com/aws/aws-sdk-cpp/blob/8f42b8167fbb31fb3c0392b58c4b6327e71afbb8/generated/src/aws-cpp-sdk-s3/include/aws/s3/S3Client.h#L105-L135).
The suggested alternatives accept subclasses of `ClientConfig`, which
may include service-specific options (like payload signing policy and
using virtual addressing for S3).

This PR moves to the new constructors when creating both S3 and STS
clients.

---
TYPE: NO_HISTORY

Author: teo-tsirpanis

tiledb/sm/filesystem/s3.cc

@@ -1348,7 +1348,7 @@ Status S3::init_client() const {
   // check for client configuration on create, which can be slow if aws is not
   // configured on a users systems due to ec2 metadata check
 
-  client_config_ = make_shared<Aws::Client::ClientConfiguration>(HERE());
+  client_config_ = make_shared<Aws::S3::S3ClientConfiguration>(HERE());
 
   s3_tp_executor_ = make_shared<S3ThreadPoolExecutor>(HERE(), vfs_thread_pool_);
 
@@ -1388,6 +1388,10 @@ Status S3::init_client() const {
       s3_params_.connect_max_tries_,
       s3_params_.connect_scale_factor_);
 
+  client_config.useVirtualAddressing = s3_params_.use_virtual_addressing_;
+  client_config.payloadSigningPolicy =
+      Aws::Client::AWSAuthV4Signer::PayloadSigningPolicy::Never;
+
   // If the user says not to sign a request, use the
   // AnonymousAWSCredentialsProvider This is equivalent to --no-sign-request on
   // the aws cli
@@ -1443,7 +1447,12 @@ Status S3::init_client() const {
                 session_name,
                 external_id,
                 load_frequency,
-                make_shared<Aws::STS::STSClient>(HERE(), client_config));
+                make_shared<Aws::STS::STSClient>(
+                    HERE(),
+                    // client_config is an S3ClientConfiguration&, but gets
+                    // casted to ClientConfiguration and copied to the STS
+                    // client configuration.
+                    Aws::STS::STSClientConfiguration(client_config)));
         break;
       }
       case 7: {
@@ -1465,9 +1474,16 @@ Status S3::init_client() const {
             HERE(),
             Aws::Auth::GetConfigProfileName(),
             std::chrono::minutes(60),
-            [client_config](const auto& credentials) {
+            [config = this->client_config_](const auto& credentials) {
               return make_shared<Aws::STS::STSClient>(
-                  HERE(), credentials, client_config);
+                  HERE(),
+                  credentials,
+                  // Create default endpoint provider.
+                  make_shared<Aws::STS::STSEndpointProvider>(HERE()),
+                  // *config is an S3ClientConfiguration&, but gets
+                  // casted to ClientConfiguration and copied to the STS
+                  // client configuration.
+                  Aws::STS::STSClientConfiguration(*config));
             });
         break;
       }
@@ -1492,20 +1508,11 @@ Status S3::init_client() const {
   {
     std::lock_guard<std::mutex> static_lck(static_client_init_mtx);
     if (credentials_provider_ == nullptr) {
-      client_ = make_shared<TileDBS3Client>(
-          HERE(),
-          s3_params_,
-          *client_config_,
-          Aws::Client::AWSAuthV4Signer::PayloadSigningPolicy::Never,
-          s3_params_.use_virtual_addressing_);
+      client_ =
+          make_shared<TileDBS3Client>(HERE(), s3_params_, *client_config_);
     } else {
       client_ = make_shared<TileDBS3Client>(
-          HERE(),
-          s3_params_,
-          credentials_provider_,
-          *client_config_,
-          Aws::Client::AWSAuthV4Signer::PayloadSigningPolicy::Never,
-          s3_params_.use_virtual_addressing_);
+          HERE(), s3_params_, credentials_provider_, *client_config_);
     }
   }
 

tiledb/sm/filesystem/s3.h

@@ -69,6 +69,7 @@
 #include <aws/core/utils/threading/Executor.h>
 #include <aws/identity-management/auth/STSAssumeRoleCredentialsProvider.h>
 #include <aws/s3/S3Client.h>
+#include <aws/s3/S3ClientConfiguration.h>
 #include <aws/s3/model/CompleteMultipartUploadRequest.h>
 #include <aws/s3/model/CopyObjectRequest.h>
 #include <aws/s3/model/CreateBucketRequest.h>
@@ -354,21 +355,20 @@ class TileDBS3Client : public Aws::S3::S3Client {
  public:
   TileDBS3Client(
       const S3Parameters& s3_params,
-      const Aws::Client::ClientConfiguration& client_config,
-      Aws::Client::AWSAuthV4Signer::PayloadSigningPolicy sign_payloads,
-      bool use_virtual_addressing)
-      : Aws::S3::S3Client(client_config, sign_payloads, use_virtual_addressing)
+      const Aws::S3::S3ClientConfiguration& client_config)
+      : Aws::S3::S3Client(client_config)
       , params_(s3_params) {
   }
 
   TileDBS3Client(
       const S3Parameters& s3_params,
       const std::shared_ptr<Aws::Auth::AWSCredentialsProvider>& creds,
-      const Aws::Client::ClientConfiguration& client_config,
-      Aws::Client::AWSAuthV4Signer::PayloadSigningPolicy sign_payloads,
-      bool use_virtual_addressing)
+      const Aws::S3::S3ClientConfiguration& client_config)
       : Aws::S3::S3Client(
-            creds, client_config, sign_payloads, use_virtual_addressing)
+            creds,
+            // Create default endpoint provider.
+            make_shared<Aws::S3::S3EndpointProvider>(HERE()),
+            client_config)
       , params_(s3_params) {
   }
 
@@ -1352,7 +1352,7 @@ class S3 : FilesystemBase {
   mutable std::mutex client_init_mtx_;
 
   /** Configuration object used to initialize the client. */
-  mutable shared_ptr<Aws::Client::ClientConfiguration> client_config_;
+  mutable shared_ptr<Aws::S3::S3ClientConfiguration> client_config_;
 
   /** The executor used by 'client_'. */
   mutable shared_ptr<S3ThreadPoolExecutor> s3_tp_executor_;