Streamline skipping tests if DenyWriteAccess is not supported. (#5683)

This happens on Windows, and when running as root (which the manylinux
CI job does).

---
TYPE: NO_HISTORY

Author: teo-tsirpanis

.github/workflows/ci-linux_mac.yml

@@ -77,7 +77,6 @@ env:
   CMAKE_GENERATOR: ${{ inputs.cmake_generator }}
   TILEDB_CI_BACKEND: ${{ inputs.ci_backend }}
   TILEDB_CI_OS: ${{ startsWith(inputs.matrix_image, 'ubuntu-') && 'Linux' || 'macOS' }}
-  TILEDB_MANYLINUX: ${{ !inputs.manylinux && 'ON' || 'OFF' }}
   CXX: ${{ inputs.matrix_compiler_cxx }}
   CC: ${{ inputs.matrix_compiler_cc }}
   CFLAGS: ${{ inputs.matrix_compiler_cflags }}
@@ -143,7 +142,7 @@ jobs:
         if: inputs.manylinux
         run: |
           set -e pipefail
-          yum install -y redhat-lsb-core perl-IPC-Cmd perl-Time-Piece curl zip unzip tar
+          dnf install -y redhat-lsb-core perl-IPC-Cmd perl-Time-Piece curl zip unzip tar
 
       # This must happen after checkout, because checkout would remove the directory.
       - name: Install Ninja

test/src/unit-capi-consolidation.cc

@@ -7537,10 +7537,6 @@ TEST_CASE_METHOD(
   if (!vfs_test_setup_.is_local()) {
     return;
   }
-  char* manylinux_var = getenv("TILEDB_MANYLINUX");
-  if (manylinux_var && strlen(manylinux_var) > 0) {
-    return;
-  }
 
   bool dense_test = true;
   std::string array_uri;
@@ -7641,10 +7637,6 @@ TEST_CASE_METHOD(
   if (!vfs_test_setup_.is_local()) {
     return;
   }
-  char* manylinux_var = getenv("TILEDB_MANYLINUX");
-  if (manylinux_var && strlen(manylinux_var) > 0) {
-    return;
-  }
 
   bool dense_test = true;
   std::string array_uri;

test/src/unit-capi-query.cc

@@ -733,10 +733,6 @@ TEST_CASE_METHOD(
   // DenyWriteAccess is not supported on Windows.
   if constexpr (tiledb::platform::is_os_windows)
     return;
-  // The test fails on Manylinux. Skip it.
-  char* manylinux_var = getenv("TILEDB_MANYLINUX");
-  if (manylinux_var && strlen(manylinux_var) > 0)
-    return;
   SupportedFsLocal local_fs;
   std::string temp_dir = local_fs.temp_dir();
   std::string array_name = temp_dir + "write_failure";

test/support/src/vfs_helpers.cc

@@ -49,6 +49,10 @@
 #include "tiledb/sm/filesystem/s3.h"
 #endif
 
+#ifndef _WIN32
+#include <unistd.h>
+#endif
+
 #include "tiledb/sm/rest/rest_client.h"
 
 namespace tiledb::test {
@@ -422,6 +426,16 @@ std::string TemporaryDirectoryFixture::create_temporary_array(
   return array_uri;
 }
 
+DenyWriteAccess::SkipOnUnsupported::SkipOnUnsupported() {
+#ifdef _WIN32
+  SKIP("DenyWriteAccess is not supported on Windows");
+#else
+  if (geteuid() == 0) {
+    SKIP("DenyWriteAccess is not supported when running as root");
+  }
+#endif
+}
+
 VFSTestBase::VFSTestBase(
     const std::vector<size_t>& test_tree, const std::string& prefix)
     : test_tree_(test_tree)

test/support/src/vfs_helpers.h

@@ -949,6 +949,21 @@ class DenyWriteAccess {
   }
 
  private:
+  /**
+   * Helper class that skips the test when constructed, if DenyWriteAccess is
+   * not supported.
+   */
+  class SkipOnUnsupported {
+   public:
+    SkipOnUnsupported();
+  };
+
+  /**
+   * Dummy object to have its constructor called, before anything else when
+   * constructing DenyWriteAccess.
+   */
+  const SkipOnUnsupported skip_on_unsupported_;
+
   /** The path. */
   const std::string path_;