Add flag for disabling file size on localfs.

VFS::ls is non-virtual and its signature varies across filesystems.
This also allows us to use a single implementation instead of duplicating the logic.

Author: shaunrd0

tiledb/sm/filesystem/azure.cc

@@ -638,7 +638,7 @@ std::vector<std::string> Azure::ls(
   return paths;
 }
 
-std::vector<directory_entry> Azure::ls_with_sizes(const URI& uri) const {
+std::vector<directory_entry> Azure::ls_with_sizes(const URI& uri, bool) const {
   return ls_with_sizes(uri, "/");
 }
 

tiledb/sm/filesystem/azure.h

@@ -459,7 +459,7 @@ class Azure : public FilesystemBase {
    * @return All entries that are contained in the prefix URI.
    */
   std::vector<tiledb::common::filesystem::directory_entry> ls_with_sizes(
-      const URI& uri) const override;
+      const URI& uri, bool get_sizes) const override;
 
   /**
    * Lists objects and object information that start with `uri`.

tiledb/sm/filesystem/failing_fs.h

@@ -88,7 +88,7 @@ class FailingFS : public FilesystemBase {
   }
 
   virtual std::vector<tiledb::common::filesystem::directory_entry>
-  ls_with_sizes(const URI&) const override {
+  ls_with_sizes(const URI&, bool) const override {
     throw get_exception();
   }
 

tiledb/sm/filesystem/filesystem_base.h

@@ -147,10 +147,11 @@ class FilesystemBase {
    * Retrieves all the entries contained in the parent.
    *
    * @param parent The target directory to list.
+   * @param get_sizes Flag to toggle retrieving file sizes.
    * @return All entries that are contained in the parent
    */
   virtual std::vector<tiledb::common::filesystem::directory_entry>
-  ls_with_sizes(const URI& parent) const = 0;
+  ls_with_sizes(const URI& parent, bool get_sizes = true) const = 0;
 
   /**
    * Lists objects and object information that start with `prefix`, invoking

tiledb/sm/filesystem/gcs.cc

@@ -510,7 +510,7 @@ std::vector<directory_entry> GCS::ls_with_sizes(
   return entries;
 }
 
-std::vector<directory_entry> GCS::ls_with_sizes(const URI& uri) const {
+std::vector<directory_entry> GCS::ls_with_sizes(const URI& uri, bool) const {
   return ls_with_sizes(uri, "/", -1);
 }
 

tiledb/sm/filesystem/gcs.h

@@ -358,7 +358,7 @@ class GCS : public FilesystemBase {
    * @return A list of directory_entry objects.
    */
   std::vector<tiledb::common::filesystem::directory_entry> ls_with_sizes(
-      const URI& uri) const override;
+      const URI& uri, bool get_sizes) const override;
 
   /**
    * Copies the directory at 'old_uri' to `new_uri`.

tiledb/sm/filesystem/mem_filesystem.cc

@@ -381,15 +381,15 @@ Status MemFilesystem::ls(
     const std::string& path, std::vector<std::string>* const paths) const {
   iassert(paths);
 
-  for (auto& fs : ls_with_sizes(URI(path))) {
+  for (auto& fs : ls_with_sizes(URI(path), true)) {
     paths->emplace_back(fs.path().native());
   }
 
   return Status::Ok();
 }
 
 std::vector<directory_entry> MemFilesystem::ls_with_sizes(
-    const URI& path) const {
+    const URI& path, bool) const {
   auto abspath = path.to_path();
   std::vector<std::string> tokens = tokenize(abspath);
 

tiledb/sm/filesystem/mem_filesystem.h

@@ -159,7 +159,7 @@ class MemFilesystem : public FilesystemBase {
    * @return A list of directory_entry objects
    */
   std::vector<tiledb::common::filesystem::directory_entry> ls_with_sizes(
-      const URI& path) const override;
+      const URI& path, bool get_sizes) const override;
 
   /**
    * Move a given filesystem path.

tiledb/sm/filesystem/posix.cc

@@ -361,7 +361,8 @@ void Posix::write(
   }
 }
 
-std::vector<directory_entry> Posix::ls_with_sizes(const URI& uri) const {
+std::vector<directory_entry> Posix::ls_with_sizes(
+    const URI& uri, bool get_sizes) const {
   std::string path = uri.to_path();
   struct dirent* next_path = nullptr;
   auto dir = PosixDIR::open(path);
@@ -379,7 +380,8 @@ std::vector<directory_entry> Posix::ls_with_sizes(const URI& uri) const {
     if (next_path->d_type == DT_DIR) {
       entries.emplace_back(abspath, 0, true);
     } else {
-      entries.emplace_back(abspath, file_size(URI(abspath)), false);
+      entries.emplace_back(
+          abspath, get_sizes ? file_size(URI(abspath)) : 0, false);
     }
   }
   return entries;

tiledb/sm/filesystem/posix.h

@@ -228,7 +228,7 @@ class Posix : public LocalFilesystem {
    * @return A list of directory_entry objects
    */
   std::vector<tiledb::common::filesystem::directory_entry> ls_with_sizes(
-      const URI& uri) const override;
+      const URI& uri, bool get_sizes) const override;
 
   /**
    * Lists files one level deep under a given path.