Fix tests.

Author: teo-tsirpanis

tiledb/common/thread_pool/test/unit_thread_pool.cc

@@ -98,12 +98,14 @@ size_t random_ms(size_t max = 3) {
  */
 void wait_all(
     ThreadPool& pool, bool use_wait, std::vector<ThreadPool::Task>& results) {
+  // Do not use REQUIRE_NOTHROW here; it will invoke more test code and Catch2's
+  // checks are not reentrant.
   if (use_wait) {
     for (auto& r : results) {
-      REQUIRE_NOTHROW(pool.wait(r));
+      pool.wait(r);
     }
   } else {
-    REQUIRE_NOTHROW(pool.wait_all(results));
+    pool.wait_all(results);
   }
 }
 
@@ -185,7 +187,7 @@ TEST_CASE(
 
     // Because the thread pool has 2 threads, the first two will probably be
     // executing at this point, but some will still be queued.
-    REQUIRE_THROWS(cancelable_tasks.cancel_all_tasks());
+    REQUIRE_NOTHROW(cancelable_tasks.cancel_all_tasks());
   }
 
   SECTION("- With cancellation callback") {
@@ -206,7 +208,7 @@ TEST_CASE(
 
     // Because the thread pool has 2 threads, the first two will probably be
     // executing at this point, but some will still be queued.
-    REQUIRE_THROWS(cancelable_tasks.cancel_all_tasks());
+    REQUIRE_NOTHROW(cancelable_tasks.cancel_all_tasks());
     REQUIRE(num_cancelled == ((int64_t)tasks.size() - result));
   }
 }

tiledb/sm/filter/test/unit_encryption_pipeline.cc

@@ -54,7 +54,8 @@ TEST_CASE("Filter: Test encryption", "[filter][encryption]") {
     pipeline.add_filter(EncryptionAES256GCMFilter(Datatype::UINT64));
 
     // No key set
-    CHECK(!pipeline.run_forward(&dummy_stats, tile.get(), nullptr, &tp).ok());
+    CHECK_THROWS(throw_if_not_ok(
+        pipeline.run_forward(&dummy_stats, tile.get(), nullptr, &tp)));
 
     // Create and set a key
     char key[32];

tiledb/sm/filter/test/unit_positive_delta_pipeline.cc

@@ -123,7 +123,8 @@ TEST_CASE("Filter: Test positive-delta encoding", "[filter][positive-delta]") {
       CHECK_NOTHROW(tile->write(&val, i * sizeof(uint64_t), sizeof(uint64_t)));
     }
 
-    CHECK(!pipeline.run_forward(&dummy_stats, tile.get(), nullptr, &tp).ok());
+    CHECK_THROWS(throw_if_not_ok(
+        pipeline.run_forward(&dummy_stats, tile.get(), nullptr, &tp)));
   }
 }
 
@@ -277,9 +278,8 @@ TEST_CASE(
       CHECK_NOTHROW(tile->write(&val, i * sizeof(uint64_t), sizeof(uint64_t)));
     }
 
-    CHECK(
-        !pipeline.run_forward(&dummy_stats, tile.get(), offsets_tile.get(), &tp)
-             .ok());
+    CHECK_THROWS(throw_if_not_ok(pipeline.run_forward(
+        &dummy_stats, tile.get(), offsets_tile.get(), &tp)));
   }
 
   WhiteboxWriterTile::set_max_tile_chunk_size(constants::max_tile_chunk_size);