Support reading V1 group details with explicit version in the name. (#4744)

[SC-41275](https://app.shortcut.com/tiledb-inc/story/41275/fix-v1-groups-written-with-latest-version)

When version 2 of the group details format was introduced in #3928 (2.16
and also backported to 2.15), the names of group details V2 files were
of the format `__t1_t2_id_version`, and V1 kept using `__t1_t2_id` for
compatibility. In #4530 (2.19), V1 files started being written with the
new format as well. This confused the group reader, which considered
group details files with names of the form `__t1_t2_id_1` as V2, merely
because they had a version field in their name.

This PR fixes the group reader, making it always consider the version if
it is present in the name of details file. The change has been validated
by writing to a V1 group and then reading from it. The test group was
created locally by Core version 2.14 and was added in
`test/inputs/groups` (its size is tiny so it can safely be stored in the
repository).

---
TYPE: BUG
DESC: Support reading V1 group details with explicit version in the
name.

Author: teo-tsirpanis

test/inputs/groups/group_v1/__group/__1708362383727_1708362383727_a464f3a3a7e740c8856a476ee4c66ce1

@@ -34,12 +34,15 @@
 #include <test/support/tdb_catch.h>
 #include "test/support/src/helpers.h"
 #include "test/support/src/serialization_wrappers.h"
+#include "test/support/src/temporary_local_directory.h"
 #include "tiledb/common/common.h"
+#include "tiledb/common/stdx_string.h"
 #include "tiledb/sm/cpp_api/tiledb"
 #include "tiledb/sm/cpp_api/tiledb_experimental"
 #include "tiledb/sm/misc/constants.h"
 
 #include <chrono>
+#include <filesystem>
 #include <iostream>
 #include <sstream>
 #include <thread>
@@ -52,6 +55,9 @@ namespace {
 static const std::string arrays_dir =
     std::string(TILEDB_TEST_INPUTS_DIR) + "/arrays";
 
+static const std::string groups_dir =
+    std::string(TILEDB_TEST_INPUTS_DIR) + "/groups";
+
 template <typename T>
 void set_query_coords(
     const Domain& domain,
@@ -1428,3 +1434,53 @@ TEST_CASE(
         g, "u64", TILEDB_UINT64, 0x7777777777777777);
   }
 }
+
+TEST_CASE(
+    "Backwards compatibility: Test v1 groups",
+    "[backwards-compat][group][v1]") {
+  Context ctx;
+  VFS vfs(ctx);
+
+  // Copy the group to a temporary directory because we will be modifying it.
+  tiledb::sm::TemporaryLocalDirectory temp_dir;
+  std::filesystem::copy(
+      groups_dir + "/group_v1",
+      temp_dir.path(),
+      std::filesystem::copy_options::recursive);
+
+  // Read the group
+  {
+    Group g{ctx, temp_dir.path(), TILEDB_READ};
+
+    CHECK(g.dump(false) != "");
+    CHECK(g.member_count() == 1);
+  }
+
+  // Add a member to the group
+  {
+    Group g{ctx, temp_dir.path(), TILEDB_WRITE};
+
+    Group::create(ctx, temp_dir.path() + "/subgroup2");
+
+    g.add_member("subgroup2", true, "subgroup2");
+
+    g.close();
+  }
+
+  // Read the group again
+  {
+    Group g{ctx, temp_dir.path(), TILEDB_READ};
+
+    CHECK(g.dump(false) != "");
+    CHECK(g.member_count() == 2);
+    CHECK(g.member(1).name() == "subgroup2");
+  }
+
+  // Read the raw group details files
+  auto children = vfs.ls(temp_dir.path() + "/__group");
+  CHECK(children.size() == 2);
+  std::sort(children.begin(), children.end());
+  CHECK(!tiledb::sm::utils::parse::ends_with(children[0], "_1"));
+  // This is the file written by this test.
+  CHECK(tiledb::sm::utils::parse::ends_with(children[1], "_1"));
+}

test/inputs/groups/group_v1/__tiledb_group.tdb

@@ -33,6 +33,7 @@
 #include "tiledb/sm/group/group.h"
 #include "tiledb/common/common.h"
 #include "tiledb/common/logger.h"
+#include "tiledb/common/stdx_string.h"
 #include "tiledb/sm/enums/datatype.h"
 #include "tiledb/sm/enums/encryption_type.h"
 #include "tiledb/sm/enums/query_type.h"
@@ -775,8 +776,12 @@ void Group::load_group_details() {
 
   // V1 groups did not have the version appended so only have 4 "_"
   // (__<timestamp>_<timestamp>_<uuid>)
+  // Since 2.19, V1 groups also have the version appended so we have
+  // to check for that as well
   auto part = latest_group_uri.last_path_part();
-  if (std::count(part.begin(), part.end(), '_') == 4) {
+  auto underscoreCount = std::count(part.begin(), part.end(), '_');
+  if (underscoreCount == 4 ||
+      (underscoreCount == 5 && utils::parse::ends_with(part, "_1"))) {
     load_group_from_uri(latest_group_uri);
     return;
   }