Debug Windows failures.

Author: shaunrd0

tiledb/sm/filesystem/local.cc

@@ -126,11 +126,6 @@ LsObjects LocalFilesystem::ls_filtered_v2(
 
 Status LocalFilesystem::ls(
     const std::string& path, std::vector<std::string>* paths) const {
-  // Noop if the parent ` path ` is not a directory, do not error out.
-  if (!is_dir(URI(path))) {
-    return Status::Ok();
-  }
-
   for (auto& fs : ls_with_sizes(URI(path), false)) {
     paths->emplace_back(fs.path().native());
   }

tiledb/sm/filesystem/posix.cc

@@ -363,6 +363,11 @@ void Posix::write(
 
 std::vector<directory_entry> Posix::ls_with_sizes(
     const URI& uri, bool get_sizes) const {
+  // Noop if the parent uri is not a directory, do not error out.
+  if (!is_dir(uri)) {
+    return {};
+  }
+
   std::string path = uri.to_path();
   struct dirent* next_path = nullptr;
   auto dir = PosixDIR::open(path);

tiledb/sm/filesystem/test/unit_uri.cc

@@ -332,7 +332,7 @@ TEST_CASE("URI: Test is_timestamped_name", "[uri][is_timestamped_name]") {
   };
   for (const auto& test : test_uris) {
     URI uri(test.first);
-    DYNAMIC_SECTION("Checking is_timestamped_name URI: " << test.first) {
+    DYNAMIC_SECTION("URI: " << test.first) {
       CHECK(uri.is_timestamped_name() == test.second);
     }
   }

tiledb/sm/filesystem/uri.cc

@@ -226,18 +226,19 @@ bool URI::is_timestamped_name() const {
 
   // Separator between uuid[_v].
   size_t uuid_separator = part.find('_', t2_separator + 1);
-  std::string uuid =
-      part.substr(t2_separator + 1, uuid_separator - t2_separator - 1);
+  std::string uuid;
   std::string suffix;
   if (uuid_separator == std::string::npos) {
     // There is no version; Check the UUID for the final suffix.
+    uuid = part.substr(t2_separator + 1);
     suffix = get_suffix(uuid);
-    uuid = uuid.substr(0, uuid.size() - suffix.size());
+    uuid.resize(uuid.size() - suffix.size());
   } else {
+    uuid = part.substr(t2_separator + 1, uuid_separator - t2_separator - 1);
     std::string version = part.substr(uuid_separator + 1);
     // Check the version for the final suffix.
     suffix = get_suffix(version);
-    version = version.substr(0, version.size() - suffix.size());
+    version.resize(version.size() - suffix.size());
     if (version.size() > std::to_string(constants::format_version).size()) {
       return false;
     }

tiledb/sm/filesystem/win.cc

@@ -350,6 +350,11 @@ bool Win::is_file(const URI& uri) const {
 
 std::vector<directory_entry> Win::ls_with_sizes(
     const URI& uri, bool get_sizes) const {
+  // Noop if the parent path is not a directory, do not error out.
+  if (!is_dir(uri)) {
+    return {};
+  }
+
   auto path = uri.to_path();
   bool ends_with_slash = path.length() > 0 && path[path.length() - 1] == '\\';
   const std::string glob = path + (ends_with_slash ? "*" : "\\*");