Skip to content

Commit ee3a9f2

Browse files
Downgrade Node.js version for manylinux jobs. (#5147)
[SC-50336](https://app.shortcut.com/tiledb-inc/story/50336/ci-failures-on-manylinux-due-to-node-js-forced-version-bump) Apparently GitHub Actions has started forcing Node.js 20 for all jobs, which causes failures for manylinux jobs due to libc version incompatibilities. This PR uses [an environment variable](https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/) to force GHA to use Node.js 16, fixing the failures until we cump manylinux in the 2.31 timeframe. --- TYPE: NO_HISTORY
1 parent dad5b03 commit ee3a9f2

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

.github/workflows/ci-linux_mac.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,9 @@ env:
8282
bootstrap_args: "--enable-ccache --vcpkg-base-triplet=${{ inputs.vcpkg_base_triplet || (startsWith(inputs.matrix_image, 'ubuntu-') && 'x64-linux' || 'x64-osx') }} ${{ inputs.bootstrap_args }} ${{ inputs.asan && '--enable-sanitizer=address' || '' }}"
8383
VCPKG_BINARY_SOURCES: 'clear;x-gha,readwrite'
8484
SCCACHE_GHA_ENABLED: "true"
85+
# Manylinux does not support Node 20 due to libc incompatibility. Temporarily opt out.
86+
# https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
87+
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: ${{ inputs.manylinux && 'true' || 'false' }}
8588

8689
jobs:
8790
build:

.github/workflows/release.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,9 @@ jobs:
6969
env:
7070
MACOSX_DEPLOYMENT_TARGET: ${{ matrix.MACOSX_DEPLOYMENT_TARGET }}
7171
VCPKG_BINARY_SOURCES: 'clear;x-gha,readwrite'
72+
# Manylinux does not support Node 20 due to libc incompatibility. Temporarily opt out.
73+
# https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
74+
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: ${{ matrix.manylinux && 'true' || 'false' }}
7275

7376
steps:
7477
- name: Checkout TileDB

0 commit comments

Comments
 (0)