Skip to content

Commit 5fe5cdf

Browse files
maxulysseFriederikeHanssentdanhornThomas
authored
Release 3.5.1 (nf-core#1799)
<!-- # nf-core/sarek pull request Many thanks for contributing to nf-core/sarek! Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs). Remember that PRs should be made against the dev branch, unless you're preparing a pipeline release. Learn more about contributing: [CONTRIBUTING.md](https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md) --> ## PR checklist - [ ] This comment contains a description of changes (with reason). - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md) - [ ] If necessary, also make a PR on the nf-core/sarek _branch_ on the [nf-core/test-datasets](https://github.com/nf-core/test-datasets) repository. - [ ] Make sure your code lints (`nf-core pipelines lint`). - [ ] Ensure the test suite passes (`nextflow run . -profile test,docker --outdir <OUTDIR>`). - [ ] Check for unexpected warnings in debug mode (`nextflow run . -profile debug,test,docker --outdir <OUTDIR>`). - [ ] Usage Documentation in `docs/usage.md` is updated. - [ ] Output Documentation in `docs/output.md` is updated. - [ ] `CHANGELOG.md` is updated. - [ ] `README.md` is updated (including new tool citations and authors/contributors). --------- Co-authored-by: Friederike Hanssen <friederike.hanssen@seqera.io> Co-authored-by: Friederike Hanssen <Friederike.hanssen@qbic.uni-tuebingen.de> Co-authored-by: tdanhorn <tdanhorn@fastmail.fm> Co-authored-by: Thomas <thomas@ideapad5.local>
1 parent ae4dd11 commit 5fe5cdf

26 files changed

+114
-70
lines changed

‎.github/workflows/cloudtest.yml‎

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -81,13 +81,24 @@ jobs:
8181
if: github.repository == 'nf-core/sarek' && github.event.review.state == 'approved' && github.event.pull_request.base.ref == 'master' || github.event_name == 'workflow_dispatch'
8282
runs-on: ubuntu-latest
8383
steps:
84-
- uses: octokit/request-action@v2.x
84+
- name: Get PR reviews
85+
uses: octokit/request-action@v2.x
86+
if: github.event_name != 'workflow_dispatch'
8587
id: check_approvals
88+
continue-on-error: true
8689
with:
87-
route: GET /repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/reviews
90+
route: GET /repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/reviews?per_page=100
8891
env:
8992
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
90-
- id: test_variables
93+
94+
- name: Check for approvals
95+
if: ${{ failure() && github.event_name != 'workflow_dispatch' }}
96+
run: |
97+
echo "No review approvals found. At least 2 approvals are required to run this action automatically."
98+
exit 1
99+
100+
- name: Check for enough approvals (>=2)
101+
id: test_variables
91102
if: github.event_name != 'workflow_dispatch'
92103
run: |
93104
JSON_RESPONSE='${{ steps.check_approvals.outputs.data }}'
@@ -114,11 +125,9 @@ jobs:
114125
}
115126
profiles: ${{ matrix.profile }}
116127

117-
- uses: actions/upload-artifact@v3
118-
name: Save Logs
119-
if: success() || failure()
128+
- uses: actions/upload-artifact@v4
120129
with:
121-
name: tower-${{ matrix.profile }}-log
130+
name: Seqera Platform debug log file
122131
path: |
123-
tower_action_*.log
124-
tower_action_*.json
132+
seqera_platform_action_*.log
133+
seqera_platform_action_*.json

‎CHANGELOG.md‎

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,37 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [3.5.1](https://github.com/nf-core/sarek/releases/tag/3.5.1) - Akkatjåkkå
9+
10+
Akkatjåkkå is another glacier.
11+
12+
### Added
13+
14+
- [1759](https://github.com/nf-core/sarek/pull/1759) - Back to dev
15+
16+
### Changed
17+
18+
- [1767](https://github.com/nf-core/sarek/pull/1767) - Bump nf-schema version to 2.2.1
19+
- [1777](https://github.com/nf-core/sarek/pull/1777) - Merge intervals for WES in GATK GenomicsDBImport
20+
- [1798](https://github.com/nf-core/sarek/pull/1798) - Prepare release 3.5.1
21+
22+
### Fixed
23+
24+
- [1797](https://github.com/nf-core/sarek/pull/1797) - Use `file-path-pattern` over `file-path` to hanlde glob for `known_indels` and `known_indels_tbi` to fix [1785](https://github.com/nf-core/sarek/issues/1785)
25+
- [1802](https://github.com/nf-core/sarek/pull/1802) - Update GHA for full_test tests
26+
27+
### Removed
28+
29+
### Dependencies
30+
31+
| Dependency | Old version | New version |
32+
| ---------- | ----------- | ----------- |
33+
34+
### Parameters
35+
36+
| Params | Status |
37+
| ------ | ------ |
38+
839
## [3.5.0](https://github.com/nf-core/sarek/releases/tag/3.5.0) - Áhkájiegna
940

1041
A set of connecting glaciers.

‎assets/multiqc_config.yml‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@ custom_logo_url: https://github.com/nf-core/sarek/
33
custom_logo_title: "nf-core/sarek"
44

55
report_comment: >
6-
This report has been generated by the <a href="https://github.com/nf-core/sarek/releases/tag/3.5.0" target="_blank">nf-core/sarek</a>
7-
analysis pipeline. For information about how to interpret these results, please see the
8-
<a href="https://nf-co.re/sarek/3.5.0/docs/output" target="_blank">documentation</a>.
6+
This report has been generated by the <a href="https://github.com/nf-core/sarek/releases/tag/3.5.1"
7+
target="_blank">nf-core/sarek</a> analysis pipeline. For information about how to
8+
interpret these results, please see the <a href="https://nf-co.re/sarek/3.5.1/docs/output"
9+
target="_blank">documentation</a>.
910
report_section_order:
1011
"nf-core-sarek-methods-description":
1112
order: -1000
@@ -41,7 +42,8 @@ module_order:
4142
name: "FastP (Read preprocessing)"
4243
- picard:
4344
name: "GATK4 MarkDuplicates"
44-
info: " metrics generated either by GATK4 MarkDuplicates or EstimateLibraryComplexity (with --use_gatk_spark)."
45+
info: " metrics generated either by GATK4 MarkDuplicates or EstimateLibraryComplexity
46+
(with --use_gatk_spark)."
4547
- samtools:
4648
name: "Samtools Flagstat"
4749
- mosdepth:
@@ -63,7 +65,7 @@ extra_fn_clean_exts:
6365
pattern: "^.*.(md|recal).mosdepth.(global|region).dist"
6466
module: mosdepth
6567

66-
sample_names_replace_regex: True
68+
sample_names_replace_regex: true
6769
sample_names_replace:
6870
"\\.[0-9]{4}$": ".md" # should match ".0001" but only at the end of strings for module Markduplicates/EstimateLibraryComplexity
6971
module: picard

‎conf/modules/joint_germline.config‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@
1616
process {
1717

1818
withName: 'GATK4_GENOMICSDBIMPORT' {
19-
ext.args = { '--genomicsdb-shared-posixfs-optimizations true --bypass-feature-reader' }
19+
ext.args = { params.wes ?
20+
'--merge-input-intervals --genomicsdb-shared-posixfs-optimizations true --bypass-feature-reader' :
21+
'--genomicsdb-shared-posixfs-optimizations true --bypass-feature-reader' }
2022
ext.prefix = { "${meta.intervals_name}.joint" }
2123
publishDir = [
2224
enabled: false

‎nextflow.config‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -336,14 +336,14 @@ env {
336336
}
337337

338338
// Set bash options
339-
process.shell = """\
340-
bash
341-
342-
set -e # Exit if a tool returns a non-zero status/exit code
343-
set -u # Treat unset variables and parameters as an error
344-
set -o pipefail # Returns the status of the last command to exit with a non-zero status or zero if all successfully execute
345-
set -C # No clobber - prevent output redirection from overwriting files.
346-
"""
339+
process.shell = [
340+
"bash",
341+
"-C", // No clobber - prevent output redirection from overwriting files.
342+
"-e", // Exit if a tool returns a non-zero status/exit code
343+
"-u", // Treat unset variables and parameters as an error
344+
"-o", // Returns the status of the last command to exit..
345+
"pipefail" // ..with a non-zero status or zero if all successfully execute
346+
]
347347

348348
// Disable process selector warnings by default. Use debug profile to enable warnings.
349349
nextflow.enable.configProcessNamesValidation = false
@@ -381,13 +381,13 @@ manifest {
381381
description = """An open-source analysis pipeline to detect germline or somatic variants from whole genome or targeted sequencing"""
382382
mainScript = 'main.nf'
383383
nextflowVersion = '!>=24.04.2'
384-
version = '3.5.0'
384+
version = '3.5.1'
385385
doi = '10.12688/f1000research.16665.2, 10.1093/nargab/lqae031, 10.5281/zenodo.3476425'
386386
}
387387

388388
// Nextflow plugins
389389
plugins {
390-
id 'nf-schema@2.1.1' // Validation of pipeline parameters and creation of an input channel from a sample sheet
390+
id 'nf-schema@2.2.1' // Validation of pipeline parameters and creation of an input channel from a sample sheet
391391
id 'nf-prov@1.2.2' // Provenance reports for pipeline runs
392392
}
393393

‎nextflow_schema.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -706,7 +706,7 @@
706706
"known_indels": {
707707
"type": "string",
708708
"fa_icon": "fas fa-copy",
709-
"format": "file-path",
709+
"format": "file-path-pattern",
710710
"exists": true,
711711
"mimetype": "text/plain",
712712
"description": "Path to known indels file.",
@@ -715,7 +715,7 @@
715715
"known_indels_tbi": {
716716
"type": "string",
717717
"fa_icon": "fas fa-copy",
718-
"format": "file-path",
718+
"format": "file-path-pattern",
719719
"exists": true,
720720
"mimetype": "text/plain",
721721
"description": "Path to known indels file index.",

‎tests/aligner-bwa-mem.nf.test.snap‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"samtools": 1.21
1818
},
1919
"Workflow": {
20-
"nf-core/sarek": "v3.5.0"
20+
"nf-core/sarek": "v3.5.1"
2121
}
2222
},
2323
[
@@ -72,7 +72,7 @@
7272
5,
7373
{
7474
"Workflow": {
75-
"nf-core/sarek": "v3.5.0"
75+
"nf-core/sarek": "v3.5.1"
7676
}
7777
},
7878
[

‎tests/aligner-bwa-mem2.nf.test.snap‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
5,
55
{
66
"Workflow": {
7-
"nf-core/sarek": "v3.5.0"
7+
"nf-core/sarek": "v3.5.1"
88
}
99
},
1010
[
@@ -60,7 +60,7 @@
6060
"samtools": 1.21
6161
},
6262
"Workflow": {
63-
"nf-core/sarek": "v3.5.0"
63+
"nf-core/sarek": "v3.5.1"
6464
}
6565
},
6666
[

‎tests/aligner-dragmap.nf.test.snap‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
5,
55
{
66
"Workflow": {
7-
"nf-core/sarek": "v3.5.0"
7+
"nf-core/sarek": "v3.5.1"
88
}
99
},
1010
[
@@ -64,7 +64,7 @@
6464
"samtools": 1.21
6565
},
6666
"Workflow": {
67-
"nf-core/sarek": "v3.5.0"
67+
"nf-core/sarek": "v3.5.1"
6868
}
6969
},
7070
[

‎tests/alignment_from_everything.nf.test.snap‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"vcftools": "0.1.16"
5252
},
5353
"Workflow": {
54-
"nf-core/sarek": "v3.5.0"
54+
"nf-core/sarek": "v3.5.1"
5555
}
5656
},
5757
[

0 commit comments

Comments
 (0)