Skip to content

Commit 5a6f0de

Browse files
committed
improve some tests
1 parent e3c7e78 commit 5a6f0de

File tree

4 files changed

+12
-14
lines changed

4 files changed

+12
-14
lines changed

src/test/java/de/tilman_neumann/jml/factor/CombinedFactorAlgorithm1ThreadTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,12 @@ public void testSmallCompositesWithSmallFactors() {
7272

7373
@Test
7474
public void testSmallCompositesWithManyFactors() {
75+
assertFullFactorizationSuccess(853079565045063L, "3 * 2389^2 * 2579 * 19319");
76+
assertFullFactorizationSuccess(641200294641979L, "1487^2 * 6791 * 42701");
77+
assertFullFactorizationSuccess(22436046236739091L, "11 * 2267^2 * 13681 * 29009");
78+
assertFullFactorizationSuccess(25702072057537247L, "83 * 1231^2 * 1777 * 114997");
79+
assertFullFactorizationSuccess(1052330620377735995L, "5 * 5107^2 * 20549 * 392699");
80+
assertFullFactorizationSuccess(772770126233127151L, "1493^2 * 11273 * 30753263");
7581
assertFullFactorizationSuccess(35184372094495L, "5 * 13^2 * 17 * 19 * 29 * 47 * 271 * 349"); // 46 bit
7682
assertFullFactorizationSuccess(1096954293075013905L, "3 * 5 * 7^2 * 169681 * 8795650783"); // 60 bit
7783
assertFullFactorizationSuccess(9223372036854775807L, "7^2 * 73 * 127 * 337 * 92737 * 649657"); // Long.MAX_VALUE = 2^63-1
@@ -203,7 +209,6 @@ public void testHarderSmallSemiprimesWithFactorsOfDifferentSize() {
203209

204210
@Test
205211
public void testSomeBiggerNumbers() {
206-
assertFullFactorizationSuccess("1100087778366101931", "3 * 7 * 43 * 89 * 199 * 263 * 307 * 881 * 967"); // Fibonacci(88), 60 bit
207212
assertFullFactorizationSuccess("15841065490425479923", "2604221509 * 6082841047"); // 64 bit
208213
assertFullFactorizationSuccess("11111111111111111111111111", "11 * 53 * 79 * 859 * 265371653 * 1058313049"); // 84 bit
209214
assertFullFactorizationSuccess("5679148659138759837165981543", "3^3 * 466932157 * 450469808245315337"); // 93 bit

src/test/java/de/tilman_neumann/jml/factor/CombinedFactorAlgorithm2ThreadsTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,12 @@ public void testSmallCompositesWithSmallFactors() {
7575

7676
@Test
7777
public void testSmallCompositesWithManyFactors() {
78+
assertFullFactorizationSuccess(853079565045063L, "3 * 2389^2 * 2579 * 19319");
79+
assertFullFactorizationSuccess(641200294641979L, "1487^2 * 6791 * 42701");
80+
assertFullFactorizationSuccess(22436046236739091L, "11 * 2267^2 * 13681 * 29009");
81+
assertFullFactorizationSuccess(25702072057537247L, "83 * 1231^2 * 1777 * 114997");
82+
assertFullFactorizationSuccess(1052330620377735995L, "5 * 5107^2 * 20549 * 392699");
83+
assertFullFactorizationSuccess(772770126233127151L, "1493^2 * 11273 * 30753263");
7884
assertFullFactorizationSuccess(35184372094495L, "5 * 13^2 * 17 * 19 * 29 * 47 * 271 * 349"); // 46 bit
7985
assertFullFactorizationSuccess(1096954293075013905L, "3 * 5 * 7^2 * 169681 * 8795650783"); // 60 bit
8086
assertFullFactorizationSuccess(9223372036854775807L, "7^2 * 73 * 127 * 337 * 92737 * 649657"); // Long.MAX_VALUE = 2^63-1
@@ -206,7 +212,6 @@ public void testHarderSmallSemiprimesWithFactorsOfDifferentSize() {
206212

207213
@Test
208214
public void testSomeBiggerNumbers() {
209-
assertFullFactorizationSuccess("1100087778366101931", "3 * 7 * 43 * 89 * 199 * 263 * 307 * 881 * 967"); // Fibonacci(88), 60 bit
210215
assertFullFactorizationSuccess("15841065490425479923", "2604221509 * 6082841047"); // 64 bit
211216
assertFullFactorizationSuccess("11111111111111111111111111", "11 * 53 * 79 * 859 * 265371653 * 1058313049"); // 84 bit
212217
assertFullFactorizationSuccess("5679148659138759837165981543", "3^3 * 466932157 * 450469808245315337"); // 93 bit

src/test/java/de/tilman_neumann/jml/factor/cfrac/CFrac63Test.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -215,10 +215,4 @@ public void testHarderSemiprimesWithFactorsOfDifferentSize() {
215215
assertFullFactorizationSuccess(8940500625246794041L, "240556271 * 37165942871"); // 63 bit
216216
assertFullFactorizationSuccess(9170754184293724117L, "290060959 * 31616644363"); // 63 bit
217217
}
218-
219-
@Test
220-
public void testNumbersWithManyFactors() {
221-
assertFullFactorizationSuccess(1096954293075013905L, "3 * 5 * 7^2 * 169681 * 8795650783");
222-
assertFullFactorizationSuccess(1100087778366101931L, "3 * 7 * 43 * 89 * 199 * 263 * 307 * 881 * 967"); // Fibonacci(88)
223-
}
224218
}

src/test/java/de/tilman_neumann/jml/factor/cfrac/CFracTest.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -216,12 +216,6 @@ public void testHarderSemiprimesWithFactorsOfDifferentSize() {
216216
assertFullFactorizationSuccess(9170754184293724117L, "290060959 * 31616644363"); // 63 bit
217217
}
218218

219-
@Test
220-
public void testNumbersWithManyFactors() {
221-
assertFullFactorizationSuccess(1096954293075013905L, "3 * 5 * 7^2 * 169681 * 8795650783");
222-
assertFullFactorizationSuccess(1100087778366101931L, "3 * 7 * 43 * 89 * 199 * 263 * 307 * 881 * 967"); // Fibonacci(88)
223-
}
224-
225219
@Test
226220
public void testSomeInputs() {
227221
assertFullFactorizationSuccess("9223372036854775807", "7^2 * 73 * 127 * 337 * 92737 * 649657"); // Long.MAX_VALUE = 2^63-1

0 commit comments

Comments
 (0)