Skip to content

Commit 39ffc15

Browse files
authored
Remove the gc call in write.jl (#271)
This gc call was added in Windows only, apparently in response to issue JuliaComputing#42. The consequence was that `writexlsx()` was much slower, with 97% of time spent on gc (in my use case). Deleting this line speeds up `writexlsx()` forty-fold and XLSX still passes all tests. Not sure what, if any, downsides there might be in other use cases.
1 parent 2d2d98b commit 39ffc15

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/write.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,6 @@ function writexlsx(output_source::Union{AbstractString, IO}, xf::XLSXFile; overw
8383
print(xlsx, generate_sst_xml_string(get_sst(xf)))
8484
end
8585
end
86-
# fix libuv issue on windows (#42)
87-
@static Sys.iswindows() ? GC.gc() : nothing
8886
nothing
8987
end
9088

0 commit comments

Comments
 (0)