Skip to content

Commit 67926db

Browse files
committed
Merge branch 'PHP-8.4' into PHP-8.5
* PHP-8.4: Fix macro check that I forgot to commit Fix UAF in tidy when tidySetErrorBuffer() fails
2 parents 18687e4 + 9e4fbb5 commit 67926db

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

ext/pdo_mysql/mysql_statement.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -748,7 +748,7 @@ static char *type_to_name_native(int type) /* {{{ */
748748
PDO_MYSQL_NATIVE_TYPE_NAME(NEWDATE)
749749
#endif
750750
/* The following 2 don't have BC FIELD_TYPE_* aliases. */
751-
#if MYSQL_VERSION_ID >= 90000 && !defined(MARIADB_BASE_VERSION) /* TODO: mysqlnd support (added in 8.4 via a1ab846231aeff49c0441a30ebd44463fc7825b1) */
751+
#if (MYSQL_VERSION_ID >= 90000 && !defined(MARIADB_BASE_VERSION)) || defined(PDO_USE_MYSQLND)
752752
PDO_MYSQL_NATIVE_TYPE_NAME(VECTOR)
753753
#endif
754754
#if MYSQL_VERSION_ID >= 50708 || defined(PDO_USE_MYSQLND)

ext/tidy/tidy.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ static zend_object *tidy_object_new(zend_class_entry *class_type, const zend_obj
387387
efree(intern->ptdoc->errbuf);
388388
tidyRelease(intern->ptdoc->doc);
389389
efree(intern->ptdoc);
390-
efree(intern);
390+
/* TODO: convert to exception */
391391
php_error_docref(NULL, E_ERROR, "Could not set Tidy error buffer");
392392
}
393393

0 commit comments

Comments
 (0)