ext/ffi: Prevent signed to unsigned comparisons

Girgias · Girgias · commit 73a31979e213 · 2025-03-31T17:03:48.000+01:00
diff --git a/ext/ffi/ffi.c b/ext/ffi/ffi.c
@@ -929,7 +929,7 @@ static void zend_ffi_callback_hash_dtor(zval *zv) /* {{{ */
 	if (callback_data->fcc.function_handler->common.fn_flags & ZEND_ACC_CLOSURE) {
 		OBJ_RELEASE(ZEND_CLOSURE_OBJECT(callback_data->fcc.function_handler));
 	}
-	for (int i = 0; i < callback_data->arg_count; ++i) {
+	for (uint32_t i = 0; i < callback_data->arg_count; ++i) {
 		if (callback_data->arg_types[i]->type == FFI_TYPE_STRUCT) {
 			efree(callback_data->arg_types[i]);
 		}
@@ -974,7 +974,7 @@ static void zend_ffi_callback_trampoline(ffi_cif* cif, void* ret, void** args, v
 	}
 
 	if (callback_data->arg_count) {
-		int n = 0;
+		uint32_t n = 0;
 
 		for (n = 0; n < callback_data->arg_count; n++) {
 			zval_ptr_dtor(&fci.params[n]);

Original file line number	Diff line number	Diff line change
`@@ -929,7 +929,7 @@ static void zend_ffi_callback_hash_dtor(zval zv) / {{{ */`
`929`	`929`	`if (callback_data->fcc.function_handler->common.fn_flags & ZEND_ACC_CLOSURE) {`
`930`	`930`	`OBJ_RELEASE(ZEND_CLOSURE_OBJECT(callback_data->fcc.function_handler));`
`931`	`931`	`}`
`932`		`- for (int i = 0; i < callback_data->arg_count; ++i) {`
	`932`	`+ for (uint32_t i = 0; i < callback_data->arg_count; ++i) {`
`933`	`933`	`if (callback_data->arg_types[i]->type == FFI_TYPE_STRUCT) {`
`934`	`934`	`efree(callback_data->arg_types[i]);`
`935`	`935`	`}`
`@@ -974,7 +974,7 @@ static void zend_ffi_callback_trampoline(ffi_cif* cif, void* ret, void** args, v`
`974`	`974`	`}`
`975`	`975`
`976`	`976`	`if (callback_data->arg_count) {`
`977`		`- int n = 0;`
	`977`	`+ uint32_t n = 0;`
`978`	`978`
`979`	`979`	`for (n = 0; n < callback_data->arg_count; n++) {`
`980`	`980`	`zval_ptr_dtor(&fci.params[n]);`