phar: Remove redundant *error check (php#20288)

ndossche · web-flow · commit 86a15f9a1bf7 · 2025-10-25T21:01:41.000+02:00
The failure of the iterator is already checked above at line 1157.
diff --git a/ext/phar/tar.c b/ext/phar/tar.c
@@ -1242,12 +1242,6 @@ ZEND_ATTRIBUTE_NONNULL_ARGS(1, 4) void phar_tar_flush(phar_archive_data *phar, z
 		php_stream_close(oldfile);
 	}
 
-	/* on error in the hash iterator above, error is set */
-	if (*error) {
-		php_stream_close(newfile);
-		return;
-	}
-
 	if (phar->fp && pass.free_fp) {
 		php_stream_close(phar->fp);
 	}

Original file line number	Diff line number	Diff line change
`@@ -1242,12 +1242,6 @@ ZEND_ATTRIBUTE_NONNULL_ARGS(1, 4) void phar_tar_flush(phar_archive_data *phar, z`
`1242`	`1242`	`php_stream_close(oldfile);`
`1243`	`1243`	`}`
`1244`	`1244`
`1245`		`- /* on error in the hash iterator above, error is set */`
`1246`		`- if (*error) {`
`1247`		`- php_stream_close(newfile);`
`1248`		`- return;`
`1249`		`- }`
`1250`		`-`
`1251`	`1245`	`if (phar->fp && pass.free_fp) {`
`1252`	`1246`	`php_stream_close(phar->fp);`
`1253`	`1247`	`}`