Skip to content

Commit b094d5a

Browse files
committed
[skip ci] Skip suspicious fpm tests on GH actions & macOS
There have been misterious macOS failures with the following error for a long time, which would usually happen 1-2x per nightly run: > The hosted runner lost communication with the server. Anything in your > workflow that terminates the runner process, starves it for CPU/Memory, or > blocks its network access can cause this error. After way too much debugging, it looks like this is caused by the two fpm tests skipped in this commit. When there's a failure, the responsible test will run for at least 120 seconds until the job is eventually killed by GitHub Actions. It's not clear yet why the tests stall. Debugging this is a PITA because the GitHub Actions log gets partially lost for killed jobs. It took an external log server to actually figure out where the job fails. Let's disable the tests first to be sure this actually solves the issue.
1 parent 9a2113a commit b094d5a

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

sapi/fpm/tests/bug74083-concurrent-reload.phpt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ Concurrent reload signals should not kill PHP-FPM master process. (Bug: #74083)
44
<?php
55
include "skipif.inc";
66
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
7+
if (getenv("GITHUB_ACTIONS") && PHP_OS_FAMILY === "Darwin") die("flaky Potential cause for GitHub Actions crash");
78
?>
89
--FILE--
910
<?php

sapi/fpm/tests/bug76601-reload-child-signals.phpt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ FPM: bug76601 children should not ignore signals during concurrent reloads
44
<?php
55
include "skipif.inc";
66
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
7+
if (getenv("GITHUB_ACTIONS") && PHP_OS_FAMILY === "Darwin") die("flaky Potential cause for GitHub Actions crash");
78
?>
89
--FILE--
910
<?php

0 commit comments

Comments
 (0)