gen_stub: stop cloning AttributeInfo objects

They are immutable

Author: DanielEScherzer

build/gen_stub.php

@@ -2085,9 +2085,6 @@ public function __clone()
             $this->args[$key] = clone $argInfo;
         }
         $this->return = clone $this->return;
-        foreach ($this->attributes as $key => $attribute) {
-            $this->attributes[$key] = clone $attribute;
-        }
         foreach ($this->framelessFunctionInfos as $key => $framelessFunctionInfo) {
             $this->framelessFunctionInfos[$key] = clone $framelessFunctionInfo;
         }
@@ -3151,9 +3148,6 @@ public function __clone()
         if ($this->type) {
             $this->type = clone $this->type;
         }
-        foreach ($this->attributes as $key => $attribute) {
-            $this->attributes[$key] = clone $attribute;
-        }
     }
 }
 
@@ -3183,6 +3177,8 @@ public function getDeclaration(array $allConstInfos): string {
     }
 }
 
+// Instances of AttributeInfo are immutable and do not need to be cloned
+// when held by an object that is cloned
 class AttributeInfo {
     public /* readonly */ string $class;
     /** @var \PhpParser\Node\Arg[] */
@@ -4012,10 +4008,6 @@ public function __clone()
         foreach ($this->funcInfos as $key => $funcInfo) {
             $this->funcInfos[$key] = clone $funcInfo;
         }
-
-        foreach ($this->attributes as $key => $attribute) {
-            $this->attributes[$key] = clone $attribute;
-        }
     }
 
     /**