ext/exif: Voidify exif_discard_imageinfo()

Girgias · Girgias · commit fbc84dd05651 · 2025-03-28T18:39:15.000Z
This always returned true, and the return value was never checked anyway
diff --git a/ext/exif/exif.c b/ext/exif/exif.c
@@ -4348,7 +4348,7 @@ static bool exif_scan_FILE_header(image_info_type *ImageInfo)
 /* {{{ exif_discard_imageinfo
    Discard data scanned by exif_read_file.
 */
-static bool exif_discard_imageinfo(image_info_type *ImageInfo)
+static void exif_discard_imageinfo(image_info_type *ImageInfo)
 {
 	int i;
 
@@ -4376,7 +4376,6 @@ static bool exif_discard_imageinfo(image_info_type *ImageInfo)
 	}
 	exif_file_sections_free(ImageInfo);
 	memset(ImageInfo, 0, sizeof(*ImageInfo));
-	return true;
 }
 /* }}} */
 

Original file line number	Diff line number	Diff line change
`@@ -4348,7 +4348,7 @@ static bool exif_scan_FILE_header(image_info_type *ImageInfo)`
`4348`	`4348`	`/* {{{ exif_discard_imageinfo`
`4349`	`4349`	`Discard data scanned by exif_read_file.`
`4350`	`4350`	`*/`
`4351`		`-static bool exif_discard_imageinfo(image_info_type *ImageInfo)`
	`4351`	`+static void exif_discard_imageinfo(image_info_type *ImageInfo)`
`4352`	`4352`	`{`
`4353`	`4353`	`int i;`
`4354`	`4354`
`@@ -4376,7 +4376,6 @@ static bool exif_discard_imageinfo(image_info_type *ImageInfo)`
`4376`	`4376`	`}`
`4377`	`4377`	`exif_file_sections_free(ImageInfo);`
`4378`	`4378`	`memset(ImageInfo, 0, sizeof(*ImageInfo));`
`4379`		`- return true;`
`4380`	`4379`	`}`
`4381`	`4380`	`/* }}} */`
`4382`	`4381`