refactor(ts-sdk): consolidate types - remove sandbox/types.ts

- Move SpeedupType to network.ts where it's used
- Update all RunMode/RunModeType imports to use common/constants.ts
- Remove unused RuntimeEnvId and AgentType from types.ts
- Delete sandbox/types.ts and types.test.ts

This addresses the PR review feedback about duplicated type definitions.

Author: Timandes

rock/ts-sdk/src/index.ts

@@ -44,7 +44,7 @@ export * from './envs/index.js';
 
 // Sandbox - selective exports
 export { Sandbox, SandboxGroup } from './sandbox/client.js';
-export type { RunModeType as SandboxRunModeType } from './sandbox/types.js';
+export type { RunModeType as SandboxRunModeType } from './common/constants.js';
 export {
   SandboxConfigSchema,
   SandboxGroupConfigSchema,
@@ -54,11 +54,10 @@ export {
 export type { SandboxConfig, SandboxGroupConfig, BaseConfig } from './sandbox/config.js';
 export { Deploy } from './sandbox/deploy.js';
 export { LinuxFileSystem } from './sandbox/file_system.js';
-export { Network } from './sandbox/network.js';
+export { Network, SpeedupType } from './sandbox/network.js';
 export { Process } from './sandbox/process.js';
 export { LinuxRemoteUser } from './sandbox/remote_user.js';
 export { withTimeLogging, arunWithRetry, extractNohupPid as extractNohupPidFromSandbox } from './sandbox/utils.js';
-export { SpeedupType } from './sandbox/types.js';
 
 // Model
 export * from './model/index.js';

rock/ts-sdk/src/sandbox/client.test.ts

@@ -4,7 +4,7 @@
 
 import axios from 'axios';
 import { Sandbox } from './client.js';
-import { RunMode } from './types.js';
+import { RunMode } from '../common/constants.js';
 import {
   BadRequestRockError,
   InternalServerRockError,

rock/ts-sdk/src/sandbox/client.ts

@@ -19,7 +19,7 @@ import { Network } from './network.js';
 import { Process } from './process.js';
 import { LinuxRemoteUser } from './remote_user.js';
 import { extractNohupPid } from './utils.js';
-import { RunModeType, RunMode as RunModeEnum } from './types.js';
+import { RunModeType, RunMode as RunModeEnum } from '../common/constants.js';
 export type { RunModeType };
 export { RunModeEnum as RunMode };
 import {

rock/ts-sdk/src/sandbox/file_system.ts

@@ -9,7 +9,7 @@ import { initLogger } from '../logger.js';
 import type { Observation, CommandResponse } from '../types/responses.js';
 import type { ChownRequest, ChmodRequest } from '../types/requests.js';
 import type { AbstractSandbox } from './client.js';
-import { RunMode } from './types.js';
+import { RunMode } from '../common/constants.js';
 import { validatePath, validateUsername, validateChmodMode, shellQuote } from '../utils/shell.js';
 
 const logger = initLogger('rock.sandbox.fs');

rock/ts-sdk/src/sandbox/index.ts

@@ -10,4 +10,8 @@ export * from './network.js';
 export * from './process.js';
 export * from './remote_user.js';
 export * from './utils.js';
-export * from './types.js';
+
+// Re-export types from their new locations
+export { SpeedupType } from './network.js';
+export type { RunModeType } from '../common/constants.js';
+export { RunMode } from '../common/constants.js';

rock/ts-sdk/src/sandbox/network.test.ts

@@ -2,8 +2,7 @@
  * Tests for Network - Network management for sandbox
  */
 
-import { Network } from './network.js';
-import { SpeedupType } from './types.js';
+import { Network, SpeedupType } from './network.js';
 import type { Observation } from '../types/responses.js';
 
 /**

rock/ts-sdk/src/sandbox/network.ts

@@ -5,11 +5,19 @@
 import { initLogger } from '../logger.js';
 import type { Observation } from '../types/responses.js';
 import type { Sandbox } from './client.js';
-import { SpeedupType } from './types.js';
 import { validateUrl, validateIpAddress, shellQuote } from '../utils/shell.js';
 
 const logger = initLogger('rock.sandbox.network');
 
+/**
+ * Speedup type enum
+ */
+export enum SpeedupType {
+  APT = 'apt',
+  PIP = 'pip',
+  GITHUB = 'github',
+}
+
 /**
  * Network management for sandbox
  */

rock/ts-sdk/src/sandbox/types.test.ts

@@ -5,7 +5,7 @@
 import { initLogger } from '../logger.js';
 import { sleep } from '../utils/retry.js';
 import type { Sandbox } from './client.js';
-import type { RunModeType } from './types.js';
+import type { RunModeType } from '../common/constants.js';
 import type { Observation } from '../types/responses.js';
 
 const logger = initLogger('rock.sandbox.utils');