1.2.0

Author: TimeStepYT

changelog.md

@@ -1,3 +1,6 @@
+### v1.2.0
+- Fixed a crash that happens if a DialogLayer scrolled without finishing the dialog first
+
 ### v1.1.9
 - Fixed a crash when not having shadows on (or Sans or Papyrus font)
 - Fixed some text tags showing with Papyrus font

mod.json

@@ -8,7 +8,7 @@
     },
     "id": "timestepyt.deltarune_textboxes",
     "name": "Deltarune Textboxes",
-    "version": "v1.1.9",
+    "version": "v1.2.0",
     "developer": "TimeStepYT",
     "description": "Makes Popups look like Deltarune",
     "links": {

src/FLAlertLayer.cpp

@@ -454,20 +454,22 @@ void DeltaruneAlertLayer::progressText() {
 
 	auto& characters = m_fields->characterSpriteNames;
 	int& dialogCount = m_fields->dialogCount;
-	if (characters.size() > 1) {
+	bool progressDialog = emptyLines > 0 && characters.size() > 1;
+	if (progressDialog) {
 		dialogCount++;
 		auto& spriteName = characters[dialogCount];
 		auto prevChar = (CCSpriteGrayscale*) m_mainLayer->getChildByID("character-sprite"_spr);
 		auto newChar = CCSpriteGrayscale::create(spriteName);
-		auto title = m_fields->titles[dialogCount];
-		auto& nameToSound = m_fields->nameToSound;
-		m_fields->title->setString(title.c_str());
 		newChar->setPosition(prevChar->getPosition());
 		newChar->setZOrder(prevChar->getZOrder());
 		m_fields->characterSprite = newChar;
-		m_mainLayer->removeChildByID("character-sprite"_spr);
-		m_mainLayer->addChild(newChar);
 		newChar->setID("character-sprite"_spr);
+		m_mainLayer->addChild(newChar);
+
+		auto title = m_fields->titles[dialogCount];
+		auto& nameToSound = m_fields->nameToSound;
+		m_fields->title->setString(title.c_str());
+		m_mainLayer->removeChildByID("character-sprite"_spr);
 		if (nameToSound.find(title.c_str()) != nameToSound.end())
 			m_fields->textSound = nameToSound[title.c_str()];
 		else