review

Author: triceo

core/src/main/java/ai/timefold/solver/core/impl/move/MoveDirector.java

@@ -235,21 +235,19 @@ public final <Entity_, Value_> Value_ moveValueInList(
                     "When moving values in the same list, sourceIndex (%d) and destinationIndex (%d) must be different."
                             .formatted(sourceIndex, destinationIndex));
         } else if (sourceIndex < 0 || destinationIndex < 0) {
-            throw new IllegalArgumentException(
-                    "The sourceIndex (%d) and destinationIndex (%d) must both be >= 0."
-                            .formatted(sourceIndex, destinationIndex));
+            throw new IndexOutOfBoundsException("The sourceIndex (%d) and destinationIndex (%d) must both be >= 0."
+                    .formatted(sourceIndex, destinationIndex));
         }
 
         var variableDescriptor = extractVariableDescriptor(variableMetaModel);
         var list = variableDescriptor.getValue(sourceEntity);
         var listSize = list.size();
         if (sourceIndex >= listSize) {
-            throw new IllegalArgumentException(
-                    "The sourceIndex (%d) must be less than the list size (%d).".formatted(sourceIndex, listSize));
+            throw new IndexOutOfBoundsException("The sourceIndex (%d) must be less than the list size (%d)."
+                    .formatted(sourceIndex, listSize));
         } else if (destinationIndex >= listSize) {
-            throw new IllegalArgumentException(
-                    "The destinationIndex (%d) must be less than the list size (%d)."
-                            .formatted(destinationIndex, listSize));
+            throw new IndexOutOfBoundsException("The destinationIndex (%d) must be less than the list size (%d)."
+                    .formatted(destinationIndex, listSize));
         }
 
         var fromIndex = Math.min(sourceIndex, destinationIndex);
@@ -270,9 +268,8 @@ public <Entity_, Value_> Value_ replaceValueInList(
                     "When replacing values in the same list, sourceIndex (%d) and replacementIndex (%d) must be different."
                             .formatted(sourceIndex, replacementIndex));
         } else if (sourceIndex < 0 || replacementIndex < 0) {
-            throw new IllegalArgumentException(
-                    "The sourceIndex (%d) and replacementIndex (%d) must both be >= 0."
-                            .formatted(sourceIndex, replacementIndex));
+            throw new IndexOutOfBoundsException("The sourceIndex (%d) and replacementIndex (%d) must both be >= 0."
+                    .formatted(sourceIndex, replacementIndex));
         }
 
         var variableDescriptor = extractVariableDescriptor(variableMetaModel);
@@ -327,7 +324,7 @@ private static <T> void moveInList(List<T> list, int from, int to) {
         }
         var lowerIndex = Math.min(from, to);
         var distanceTimesEight = (long) distance * 8L; // Prevents unlikely yet possible overflow.
-        var tailLength = (long) list.size() - lowerIndex;
+        var tailLength = list.size() - lowerIndex;
         if (distanceTimesEight < tailLength) {
             Collections.rotate(list.subList(lowerIndex, lowerIndex + distance + 1), from < to ? -1 : 1);
         } else {

core/src/main/java/ai/timefold/solver/core/preview/api/move/MutableSolutionView.java

@@ -230,7 +230,6 @@ default <Entity_, Value_> Value_ moveValueBetweenLists(
      *        Acceptable values range from zero to one less than list size.
      *        All values at or after the index are shifted to the right.
      * @return the value that was moved
-     * @throws IndexOutOfBoundsException if either index is out of bounds
      * @throws IllegalArgumentException if sourceIndex == destinationIndex
      * @see #replaceValueInList(PlanningListVariableMetaModel, Object, int, int) Similar operation that replaces the value at
      *      the destination index instead.
@@ -255,7 +254,6 @@ <Entity_, Value_> Value_ moveValueInList(PlanningListVariableMetaModel<Solution_
      *        Acceptable values range from zero to one less than list size.
      *        The value previously at this index is unassigned.
      * @return the value that was replaced
-     * @throws IndexOutOfBoundsException if either index is out of bounds
      * @throws IllegalArgumentException if sourceIndex == replacementIndex
      * @see #moveValueInList(PlanningListVariableMetaModel, Object, int, int) Similar operation that moves the value to the
      *      destination index instead.

core/src/test/java/ai/timefold/solver/core/impl/move/MoveDirectorTest.java

@@ -1445,7 +1445,7 @@ void replaceValueInListThrowsOnNegativeIndex() {
             var mockScoreDirector = (InnerScoreDirector<TestdataListSolution, ?>) mock(InnerScoreDirector.class);
             var moveDirector = new MoveDirector<>(mockScoreDirector);
             Assertions.assertThatThrownBy(() -> moveDirector.replaceValueInList(variableMetaModel, entity, -1, 1))
-                    .isInstanceOf(IllegalArgumentException.class);
+                    .isInstanceOf(IndexOutOfBoundsException.class);
         }
 
         @Test