chore: address comments

Author: zepfred

core/src/main/java/ai/timefold/solver/core/impl/domain/variable/declarative/DeclarativeShadowVariableDescriptor.java

@@ -53,9 +53,9 @@ public void processAnnotations(DescriptorPolicy descriptorPolicy) {
 
         if (method == null) {
             throw new IllegalArgumentException("""
-                    @%s (%s) defines a supplierMethod (%s) that does not exist inside its declaring class (%s).
-                    Maybe you misspelled the supplierMethod name?
-                    Maybe you have included a unallowed parameter, which does not match the expected solution class: %s"""
+                    @%s (%s) defines a supplierName (%s) that does not exist inside its declaring class (%s).
+                    Maybe you misspelled the supplierName name?
+                    Maybe you have included a disallowed parameter, which does not match the expected solution class: %s"""
                     .formatted(ShadowVariable.class.getSimpleName(), variableName, methodName,
                             variableMemberAccessor.getDeclaringClass().getCanonicalName(), solutionClass.getName()));
         }

core/src/test/java/ai/timefold/solver/core/impl/domain/solution/descriptor/SolutionDescriptorTest.java

@@ -420,12 +420,13 @@ void testBadChainedAndListModel() {
     }
 
     @Test
-    void missingDeclarativeSupplierMethod() {
+    void missingDeclarativeSupplierName() {
         assertThatCode(TestdataDeclarativeMissingSupplierSolution::buildSolutionDescriptor)
                 .hasMessageContainingAll("@ShadowVariable (endTime)",
-                        "supplierMethod (calculateEndTime) that does not exist",
+                        "supplierName (calculateEndTime) that does not exist",
                         "inside its declaring class (ai.timefold.solver.core.testdomain.shadow.missing.TestdataDeclarativeMissingSupplierValue).",
-                        "Maybe you misspelled the supplierMethod name?");
+                        "Maybe you misspelled the supplierName name?",
+                        "Maybe you have included a disallowed parameter, which does not match the expected solution class: ai.timefold.solver.core.testdomain.shadow.missing.");
     }
 
     @Test

core/src/test/java/ai/timefold/solver/core/impl/domain/variable/declarative/RootVariableSourceTest.java

@@ -634,7 +634,7 @@ void invalidParameter() {
                 TestdataInvalidDeclarativeParameterValue.class)
                 .getMetaModel())
                 .hasMessageContaining(
-                        "Maybe you have included a unallowed parameter, which does not match the expected solution class");
+                        "Maybe you have included a disallowed parameter, which does not match the expected solution class");
     }
 
     @Test

core/src/test/java/ai/timefold/solver/core/testdomain/shadow/parameter/TestdataBasicVarParameterEntity.java

@@ -50,7 +50,7 @@ public long getDurationInDays() {
 
     @Override
     public String toString() {
-        return "TestdataBasicVarEntity{" +
+        return "TestdataBasicVarParameterEntity{" +
                 "id=" + id +
                 ", value=" + value +
                 '}';

core/src/test/java/ai/timefold/solver/core/testdomain/shadow/parameter/TestdataBasicVarParameterSolution.java

@@ -78,7 +78,7 @@ public void setScore(HardSoftScore score) {
 
     @Override
     public String toString() {
-        return "TestdataBasicVarSolution{" +
+        return "TestdataBasicVarParameterSolution{" +
                 "entities=" + entities +
                 ", values=" + values +
                 ", problemFacts=" + problemFacts +

quarkus-integration/quarkus/deployment/src/main/java/ai/timefold/solver/quarkus/deployment/TimefoldProcessor.java

@@ -1062,9 +1062,9 @@ private GeneratedGizmoClasses generateDomainAccessors(Map<String, SolverConfig>
                     if (methodInfo == null) {
                         throw new IllegalArgumentException(
                                 """
-                                        @%s (%s) defines a supplierMethod (%s) that does not exist inside its declaring class (%s).
-                                        Maybe you misspelled the supplierMethod name?
-                                        Maybe you have included a unallowed parameter, which does not match the expected solution class: %s"""
+                                        @%s (%s) defines a supplierName (%s) that does not exist inside its declaring class (%s).
+                                        Maybe you misspelled the supplierName name?
+                                        Maybe you have included a disallowed parameter, which does not match the expected solution class: %s"""
                                         .formatted(ShadowVariable.class.getSimpleName(), memberName, targetMethodName,
                                                 classInfo.name().toString(), solutionClassInfo.name().toString()));
                     }

quarkus-integration/quarkus/deployment/src/test/java/ai/timefold/solver/quarkus/TimefoldProcessorMissingSupplierForDeclarativeVariableTest.java

@@ -30,9 +30,9 @@ class TimefoldProcessorMissingSupplierForDeclarativeVariableTest {
                     .isInstanceOf(IllegalArgumentException.class)
                     .hasMessageContainingAll(
                             "@ShadowVariable (endTime)",
-                            "supplierMethod (calculateEndTime) that does not exist",
+                            "supplierName (calculateEndTime) that does not exist",
                             "inside its declaring class (ai.timefold.solver.quarkus.testdomain.declarative.missing.TestdataQuarkusDeclarativeMissingSupplierValue).",
-                            "Maybe you misspelled the supplierMethod name?"));
+                            "Maybe you misspelled the supplierName name?"));
 
     @Test
     void test() {

spring-integration/spring-boot-autoconfigure/src/test/java/ai/timefold/solver/spring/boot/autoconfigure/TimefoldSolverSingleSolverAutoConfigurationTest.java

@@ -252,9 +252,9 @@ void missingSupplierVariables() {
                         "timefold.solver.termination.best-score-limit=0")
                 .run(context -> context.getBean(SolverFactory.class)))
                 .hasMessageContainingAll("@ShadowVariable (value1AndValue2)",
-                        "supplierMethod (value1AndValue2Supplier) that does not exist",
+                        "supplierName (value1AndValue2Supplier) that does not exist",
                         "inside its declaring class (ai.timefold.solver.spring.boot.autoconfigure.missingsuppliervariable.domain.TestdataSpringMissingSupplierVariableEntity).",
-                        "Maybe you misspelled the supplierMethod name?");
+                        "Maybe you misspelled the supplierName name?");
     }
 
     @Test