Skip to content

Commit 802807a

Browse files
committed
chore: fix cherry-picks
1 parent 5d6bd81 commit 802807a

File tree

5 files changed

+14
-13
lines changed

5 files changed

+14
-13
lines changed

core/core-impl/src/main/java/ai/timefold/solver/core/impl/domain/solution/cloner/FieldAccessingSolutionCloner.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,11 @@ public Object gizmoFallbackDeepClone(Object originalValue, Map<Object, Object> o
7272
}
7373
Queue<Unprocessed> unprocessedQueue = new ArrayDeque<>();
7474
Class<?> fieldType = originalValue.getClass();
75-
if (originalValue instanceof Collection<?> collection) {
76-
return cloneCollection(fieldType, collection, originalToCloneMap, unprocessedQueue);
77-
} else if (originalValue instanceof Map<?, ?> map) {
78-
return cloneMap(fieldType, map, originalToCloneMap, unprocessedQueue);
75+
if (originalValue instanceof Collection<?>) {
76+
return cloneCollection(fieldType, (Collection<? extends Object>) originalValue, originalToCloneMap,
77+
unprocessedQueue);
78+
} else if (originalValue instanceof Map<?, ?>) {
79+
return cloneMap(fieldType, (Map<?, ?>) originalValue, originalToCloneMap, unprocessedQueue);
7980
} else if (originalValue.getClass().isArray()) {
8081
return cloneArray(fieldType, originalValue, originalToCloneMap, unprocessedQueue);
8182
} else {

core/core-impl/src/main/java/ai/timefold/solver/core/impl/domain/solution/cloner/gizmo/GizmoSolutionClonerImplementor.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -852,7 +852,7 @@ private void writeDeepCloneEntityOrFactInstructions(BytecodeCreator bytecodeCrea
852852
List<Class<?>> deepClonedSubclasses = deepClonedClassesSortedSet.stream()
853853
.filter(deeplyClonedFieldClass::isAssignableFrom)
854854
.filter(type -> DeepCloningUtils.isClassDeepCloned(solutionDescriptor.getSolutionDescriptor(), type))
855-
.toList();
855+
.collect(Collectors.toList());
856856
BytecodeCreator currentBranch = bytecodeCreator;
857857
// If the field holds an instance of one of the field's declared type's subtypes, clone the subtype instead.
858858
for (Class<?> deepClonedSubclass : deepClonedSubclasses) {
@@ -870,18 +870,18 @@ private void writeDeepCloneEntityOrFactInstructions(BytecodeCreator bytecodeCrea
870870
// We are certain that the instance is of the same type as the declared field type.
871871
// (Or is an undeclared subclass of the planning entity)
872872
switch (unhandledCloneType) {
873-
case SHALLOW -> {
873+
case SHALLOW:
874874
currentBranch.assign(cloneResultHolder, toClone);
875-
}
876-
case DEEP -> {
875+
break;
876+
case DEEP:
877877
ResultHandle cloneObj = currentBranch.invokeStaticMethod(
878878
MethodDescriptor.ofMethod(
879879
GizmoSolutionClonerFactory.getGeneratedClassName(solutionDescriptor.getSolutionDescriptor()),
880880
getEntityHelperMethodName(deeplyClonedFieldClass), deeplyClonedFieldClass,
881881
deeplyClonedFieldClass, Map.class),
882882
toClone, createdCloneMap);
883883
currentBranch.assign(cloneResultHolder, cloneObj);
884-
}
884+
break;
885885
}
886886
}
887887

core/core-impl/src/main/java/ai/timefold/solver/core/impl/domain/solution/descriptor/SolutionDescriptor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -589,8 +589,8 @@ private void initSolutionCloner(DescriptorPolicy descriptorPolicy) {
589589
.get(GizmoSolutionClonerFactory.getGeneratedClassName(this))
590590
: solutionCloner;
591591

592-
if (solutionCloner instanceof GizmoSolutionCloner<Solution_> gizmoSolutionCloner) {
593-
gizmoSolutionCloner.setSolutionDescriptor(this);
592+
if (solutionCloner instanceof GizmoSolutionCloner) {
593+
((GizmoSolutionCloner<Solution_>) solutionCloner).setSolutionDescriptor(this);
594594
}
595595
if (solutionCloner == null) {
596596
switch (descriptorPolicy.getDomainAccessType()) {

quarkus-integration/quarkus/deployment/src/test/java/ai/timefold/solver/quarkus/TimefoldProcessorExtendedShadowSolutionSolveTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
import java.util.concurrent.ExecutionException;
88

9-
import jakarta.inject.Inject;
9+
import javax.inject.Inject;
1010

1111
import ai.timefold.solver.core.api.solver.SolverJob;
1212
import ai.timefold.solver.core.api.solver.SolverManager;

quarkus-integration/quarkus/deployment/src/test/java/ai/timefold/solver/quarkus/TimefoldProcessorShadowVariableSolveTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import java.util.stream.Collectors;
99
import java.util.stream.IntStream;
1010

11-
import jakarta.inject.Inject;
11+
import javax.inject.Inject;
1212

1313
import ai.timefold.solver.core.api.score.ScoreManager;
1414
import ai.timefold.solver.core.api.score.buildin.simple.SimpleScore;

0 commit comments

Comments
 (0)