Complete the first level of test coverage

Author: triceo

core/src/main/java/ai/timefold/solver/core/impl/bavet/uni/AbstractForEachUniNode.java

@@ -1,18 +1,19 @@
 package ai.timefold.solver.core.impl.bavet.uni;
 
+import java.util.IdentityHashMap;
+import java.util.Map;
+
 import ai.timefold.solver.core.impl.bavet.common.AbstractNode;
 import ai.timefold.solver.core.impl.bavet.common.Propagator;
 import ai.timefold.solver.core.impl.bavet.common.StaticPropagationQueue;
 import ai.timefold.solver.core.impl.bavet.common.tuple.TupleLifecycle;
 import ai.timefold.solver.core.impl.bavet.common.tuple.TupleState;
 import ai.timefold.solver.core.impl.bavet.common.tuple.UniTuple;
 import ai.timefold.solver.core.impl.score.director.SessionContext;
+
 import org.jspecify.annotations.NullMarked;
 import org.jspecify.annotations.Nullable;
 
-import java.util.IdentityHashMap;
-import java.util.Map;
-
 /**
  * Filtering nodes are expensive.
  * Considering that most streams start with a nullity check on genuine planning variables,

core/src/main/java/ai/timefold/solver/core/impl/domain/solution/descriptor/DefaultPlanningListVariableMetaModel.java

@@ -27,14 +27,9 @@ public String name() {
         return variableDescriptor.getVariableName();
     }
 
-    @Override
-    public boolean hasValueRangeOnEntity() {
-        return !variableDescriptor.canExtractValueRangeFromSolution();
-    }
-
     @Override
     public boolean allowsUnassignedValues() {
-        return false;
+        return variableDescriptor.allowsUnassignedValues();
     }
 
     @Override

core/src/main/java/ai/timefold/solver/core/impl/domain/solution/descriptor/DefaultPlanningVariableMetaModel.java

@@ -27,11 +27,6 @@ public String name() {
         return variableDescriptor.getVariableName();
     }
 
-    @Override
-    public boolean hasValueRangeOnEntity() {
-        return !variableDescriptor.canExtractValueRangeFromSolution();
-    }
-
     @Override
     public boolean allowsUnassigned() {
         return variableDescriptor.allowsUnassigned();

core/src/main/java/ai/timefold/solver/core/impl/localsearch/DefaultLocalSearchPhaseFactory.java

@@ -1,5 +1,10 @@
 package ai.timefold.solver.core.impl.localsearch;
 
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Objects;
+
 import ai.timefold.solver.core.api.domain.entity.PinningFilter;
 import ai.timefold.solver.core.api.domain.entity.PlanningPin;
 import ai.timefold.solver.core.api.domain.variable.PlanningListVariable;
@@ -45,11 +50,6 @@
 import ai.timefold.solver.core.impl.solver.termination.SolverTermination;
 import ai.timefold.solver.core.preview.api.domain.metamodel.PlanningVariableMetaModel;
 
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.List;
-import java.util.Objects;
-
 public class DefaultLocalSearchPhaseFactory<Solution_> extends AbstractPhaseFactory<Solution_, LocalSearchPhaseConfig> {
 
     public DefaultLocalSearchPhaseFactory(LocalSearchPhaseConfig phaseConfig) {

core/src/main/java/ai/timefold/solver/core/impl/move/director/MoveDirector.java

@@ -1,5 +1,9 @@
 package ai.timefold.solver.core.impl.move.director;
 
+import java.util.List;
+import java.util.Objects;
+import java.util.function.BiFunction;
+
 import ai.timefold.solver.core.api.score.Score;
 import ai.timefold.solver.core.impl.domain.entity.descriptor.EntityDescriptor;
 import ai.timefold.solver.core.impl.domain.solution.descriptor.DefaultPlanningListVariableMetaModel;
@@ -18,13 +22,10 @@
 import ai.timefold.solver.core.preview.api.domain.metamodel.PlanningVariableMetaModel;
 import ai.timefold.solver.core.preview.api.move.Move;
 import ai.timefold.solver.core.preview.api.move.Rebaser;
+
 import org.jspecify.annotations.NullMarked;
 import org.jspecify.annotations.Nullable;
 
-import java.util.List;
-import java.util.Objects;
-import java.util.function.BiFunction;
-
 @NullMarked
 public sealed class MoveDirector<Solution_, Score_ extends Score<Score_>>
         implements InnerMutableSolutionView<Solution_>, Rebaser

core/src/main/java/ai/timefold/solver/core/impl/move/streams/DefaultMoveStreamFactory.java

@@ -5,10 +5,10 @@
 import ai.timefold.solver.core.impl.domain.solution.descriptor.DefaultPlanningVariableMetaModel;
 import ai.timefold.solver.core.impl.domain.solution.descriptor.SolutionDescriptor;
 import ai.timefold.solver.core.impl.domain.variable.descriptor.GenuineVariableDescriptor;
-import ai.timefold.solver.core.impl.move.streams.dataset.bi.AbstractBiDataStream;
-import ai.timefold.solver.core.impl.move.streams.dataset.uni.AbstractUniDataStream;
 import ai.timefold.solver.core.impl.move.streams.dataset.DataStreamFactory;
 import ai.timefold.solver.core.impl.move.streams.dataset.DatasetSessionFactory;
+import ai.timefold.solver.core.impl.move.streams.dataset.bi.AbstractBiDataStream;
+import ai.timefold.solver.core.impl.move.streams.dataset.uni.AbstractUniDataStream;
 import ai.timefold.solver.core.impl.move.streams.maybeapi.DataJoiners;
 import ai.timefold.solver.core.impl.move.streams.maybeapi.stream.BiDataStream;
 import ai.timefold.solver.core.impl.move.streams.maybeapi.stream.BiMoveStream;

core/src/main/java/ai/timefold/solver/core/impl/move/streams/DefaultMoveStreamSession.java

@@ -1,15 +1,16 @@
 package ai.timefold.solver.core.impl.move.streams;
 
+import java.util.Objects;
+
+import ai.timefold.solver.core.impl.move.streams.dataset.DatasetSession;
 import ai.timefold.solver.core.impl.move.streams.dataset.bi.BiDataset;
 import ai.timefold.solver.core.impl.move.streams.dataset.bi.BiDatasetInstance;
-import ai.timefold.solver.core.impl.move.streams.dataset.DatasetSession;
 import ai.timefold.solver.core.impl.move.streams.dataset.uni.UniDataset;
 import ai.timefold.solver.core.impl.move.streams.dataset.uni.UniDatasetInstance;
 import ai.timefold.solver.core.impl.move.streams.maybeapi.stream.MoveStreamSession;
 import ai.timefold.solver.core.preview.api.move.SolutionView;
-import org.jspecify.annotations.NullMarked;
 
-import java.util.Objects;
+import org.jspecify.annotations.NullMarked;
 
 @NullMarked
 public final class DefaultMoveStreamSession<Solution_>

core/src/main/java/ai/timefold/solver/core/impl/move/streams/FromBiUniMoveProducer.java

@@ -1,22 +1,23 @@
 package ai.timefold.solver.core.impl.move.streams;
 
+import java.util.Iterator;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.Random;
+import java.util.Set;
+import java.util.function.Supplier;
+
 import ai.timefold.solver.core.impl.bavet.common.tuple.BiTuple;
-import ai.timefold.solver.core.impl.move.streams.dataset.common.AbstractDataStream;
 import ai.timefold.solver.core.impl.move.streams.dataset.bi.BiDataset;
+import ai.timefold.solver.core.impl.move.streams.dataset.common.AbstractDataStream;
 import ai.timefold.solver.core.impl.move.streams.maybeapi.stream.BiMoveConstructor;
 import ai.timefold.solver.core.impl.move.streams.maybeapi.stream.MoveStreamSession;
 import ai.timefold.solver.core.preview.api.move.Move;
 import ai.timefold.solver.core.preview.api.move.SolutionView;
+
 import org.jspecify.annotations.NullMarked;
 import org.jspecify.annotations.Nullable;
 
-import java.util.Iterator;
-import java.util.NoSuchElementException;
-import java.util.Objects;
-import java.util.Random;
-import java.util.Set;
-import java.util.function.Supplier;
-
 @NullMarked
 public final class FromBiUniMoveProducer<Solution_, A, B> implements InnerMoveProducer<Solution_> {
 

core/src/main/java/ai/timefold/solver/core/impl/move/streams/FromUniBiMoveProducer.java

@@ -1,23 +1,24 @@
 package ai.timefold.solver.core.impl.move.streams;
 
+import java.util.Iterator;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.Random;
+import java.util.Set;
+import java.util.function.BiPredicate;
+import java.util.function.Supplier;
+
 import ai.timefold.solver.core.impl.bavet.common.tuple.UniTuple;
 import ai.timefold.solver.core.impl.move.streams.dataset.common.AbstractDataStream;
 import ai.timefold.solver.core.impl.move.streams.dataset.uni.UniDataset;
 import ai.timefold.solver.core.impl.move.streams.maybeapi.stream.BiMoveConstructor;
 import ai.timefold.solver.core.impl.move.streams.maybeapi.stream.MoveStreamSession;
 import ai.timefold.solver.core.preview.api.move.Move;
 import ai.timefold.solver.core.preview.api.move.SolutionView;
+
 import org.jspecify.annotations.NullMarked;
 import org.jspecify.annotations.Nullable;
 
-import java.util.Iterator;
-import java.util.NoSuchElementException;
-import java.util.Objects;
-import java.util.Random;
-import java.util.Set;
-import java.util.function.BiPredicate;
-import java.util.function.Supplier;
-
 @NullMarked
 public final class FromUniBiMoveProducer<Solution_, A, B> implements InnerMoveProducer<Solution_> {
 

core/src/main/java/ai/timefold/solver/core/impl/move/streams/dataset/DataStreamFactory.java

@@ -1,5 +1,13 @@
 package ai.timefold.solver.core.impl.move.streams.dataset;
 
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.function.Consumer;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
 import ai.timefold.solver.core.config.solver.EnvironmentMode;
 import ai.timefold.solver.core.impl.domain.solution.descriptor.InnerGenuineVariableMetaModel;
 import ai.timefold.solver.core.impl.domain.solution.descriptor.SolutionDescriptor;
@@ -13,15 +21,8 @@
 import ai.timefold.solver.core.impl.move.streams.maybeapi.stream.UniDataStream;
 import ai.timefold.solver.core.impl.score.director.SessionContext;
 import ai.timefold.solver.core.preview.api.domain.metamodel.GenuineVariableMetaModel;
-import org.jspecify.annotations.NullMarked;
 
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.Objects;
-import java.util.function.Consumer;
-import java.util.stream.Collectors;
-import java.util.stream.Stream;
+import org.jspecify.annotations.NullMarked;
 
 @NullMarked
 public final class DataStreamFactory<Solution_> {