fix warnings on compiler for macos and powershell fix for prebuild steps

Author: TimelordUK

.github/workflows/prebuild.yml

@@ -67,12 +67,25 @@ jobs:
     - name: Prebuild binaries
       run: npx prebuild --strip
 
-    - name: List generated prebuilds
+    - name: List generated prebuilds (Unix)
+      if: runner.os != 'Windows'
       run: |
         echo "=== Generated prebuilds ==="
         find prebuilds -type f -name "*.tar.gz" 2>/dev/null || echo "No tar.gz files found"
         ls -la prebuilds/ || echo "prebuilds directory not found"
 
+    - name: List generated prebuilds (Windows)
+      if: runner.os == 'Windows'
+      shell: powershell
+      run: |
+        Write-Host "=== Generated prebuilds ==="
+        if (Test-Path prebuilds) {
+          Get-ChildItem -Path prebuilds -Filter "*.tar.gz" -Recurse | ForEach-Object { $_.FullName }
+          Get-ChildItem -Path prebuilds
+        } else {
+          Write-Host "prebuilds directory not found"
+        }
+
     - name: Upload to GitHub Release
       if: startsWith(github.ref, 'refs/tags/')
       run: npx prebuild --upload-all
@@ -132,12 +145,25 @@ jobs:
     - name: Prebuild Electron binaries
       run: npx prebuild -r electron -t ${{ matrix.electron }}.0.0 --strip
 
-    - name: List generated Electron prebuilds
+    - name: List generated Electron prebuilds (Unix)
+      if: runner.os != 'Windows'
       run: |
         echo "=== Generated Electron prebuilds ==="
         find prebuilds -type f -name "*.tar.gz" 2>/dev/null || echo "No tar.gz files found"
         ls -la prebuilds/ || echo "prebuilds directory not found"
 
+    - name: List generated Electron prebuilds (Windows)
+      if: runner.os == 'Windows'
+      shell: powershell
+      run: |
+        Write-Host "=== Generated Electron prebuilds ==="
+        if (Test-Path prebuilds) {
+          Get-ChildItem -Path prebuilds -Filter "*.tar.gz" -Recurse | ForEach-Object { $_.FullName }
+          Get-ChildItem -Path prebuilds
+        } else {
+          Write-Host "prebuilds directory not found"
+        }
+
     - name: Upload to GitHub Release
       if: startsWith(github.ref, 'refs/tags/')
       run: npx prebuild -r electron --upload-all

cpp/src/js/columns/binary_column.cpp

@@ -19,7 +19,7 @@ Napi::Object BinaryColumn::ToString(Napi::Env env) {
   hex.reserve(len * 2);
   for (size_t i = 0; i < len; ++i) {
     char buf[3];
-    sprintf(buf, "%02X", static_cast<unsigned char>(s[i]));
+    snprintf(buf, sizeof(buf), "%02X", static_cast<unsigned char>(s[i]));
     hex += buf;
   }
   return Napi::String::New(env, hex).As<Napi::Object>();

cpp/src/odbc/odbc_statement.cpp

@@ -18,7 +18,7 @@
 const int SQL_SERVER_MAX_STRING_SIZE = 8000;
 
 // default size to retrieve from a LOB field and we don't know the size
-const int LOB_PACKET_SIZE = 8192;
+// const int LOB_PACKET_SIZE = 8192;  // Currently unused
 
 namespace mssql {
 enum class ExecutionState { Initial, Prepared, Executed, Completed, Error };

cpp/src/odbc/odbc_statement_legacy.cpp

@@ -21,7 +21,7 @@
 const int SQL_SERVER_MAX_STRING_SIZE = 8000;
 
 // default size to retrieve from a LOB field and we don't know the size
-const int LOB_PACKET_SIZE = 8192;
+// const int LOB_PACKET_SIZE = 8192;  // Currently unused
 
 namespace mssql {
 
@@ -1988,7 +1988,7 @@ bool OdbcStatementLegacy::lob(const size_t row_id, size_t column) {
   }
 
   // Track the total actual bytes of data we've read
-  SQLLEN total_bytes_read = 0;
+  // SQLLEN total_bytes_read = 0;  // Currently unused but kept for potential future use
 
   if (!check_odbc_error(r)) {
     SQL_LOG_DEBUG_STREAM("[" << _handle.toString() << "] lob failed to get data " << r);
@@ -2004,10 +2004,10 @@ bool OdbcStatementLegacy::lob(const size_t row_id, size_t column) {
   // For the first read, if all data fit, total_bytes_to_read contains the actual byte count
   if (!more) {
     // All data fit in first read
-    total_bytes_read = capture.total_bytes_to_read;
+    // total_bytes_read = capture.total_bytes_to_read;
   } else {
     // Data didn't fit, we need to read in chunks
-    total_bytes_read = capture.bytes_to_read;
+    // total_bytes_read = capture.bytes_to_read;
   }
 
   capture.on_first_read();
@@ -2032,7 +2032,7 @@ bool OdbcStatementLegacy::lob(const size_t row_id, size_t column) {
     }
 
     // Add the bytes from this chunk
-    total_bytes_read += capture.bytes_to_read;
+    // total_bytes_read += capture.bytes_to_read;
 
     more = check_more_read(r, status);
     if (!status) {