Tidy some logging uses

Author: frankmcsherry

differential-dataflow/examples/bfs.rs

@@ -7,7 +7,6 @@ use differential_dataflow::input::Input;
 use differential_dataflow::Collection;
 use differential_dataflow::operators::*;
 use differential_dataflow::lattice::Lattice;
-use differential_dataflow::logging::DifferentialEventBuilder;
 
 type Node = u32;
 type Edge = (Node, Node);
@@ -23,22 +22,6 @@ fn main() {
     // define a new computational scope, in which to run BFS
     timely::execute_from_args(std::env::args(), move |worker| {
 
-        if let Ok(addr) = ::std::env::var("DIFFERENTIAL_LOG_ADDR") {
-
-            eprintln!("enabled DIFFERENTIAL logging to {}", addr);
-
-            if let Ok(stream) = ::std::net::TcpStream::connect(&addr) {
-                let writer = ::timely::dataflow::operators::capture::EventWriter::new(stream);
-                let mut logger = ::timely::logging::BatchLogger::new(writer);
-                worker.log_register().unwrap().insert::<DifferentialEventBuilder,_>("differential/arrange", move |time, data|
-                    logger.publish_batch(time, data)
-                );
-            }
-            else {
-                panic!("Could not connect to differential log address: {:?}", addr);
-            }
-        }
-
         let timer = ::std::time::Instant::now();
 
         // define BFS dataflow; return handles to roots and edges inputs

differential-dataflow/examples/dynamic.rs

@@ -7,7 +7,6 @@ use differential_dataflow::input::Input;
 use differential_dataflow::Collection;
 use differential_dataflow::operators::*;
 use differential_dataflow::lattice::Lattice;
-use differential_dataflow::logging::DifferentialEventBuilder;
 
 type Node = u32;
 type Edge = (Node, Node);
@@ -23,22 +22,6 @@ fn main() {
     // define a new computational scope, in which to run BFS
     timely::execute_from_args(std::env::args(), move |worker| {
 
-        if let Ok(addr) = ::std::env::var("DIFFERENTIAL_LOG_ADDR") {
-
-            eprintln!("enabled DIFFERENTIAL logging to {}", addr);
-
-            if let Ok(stream) = ::std::net::TcpStream::connect(&addr) {
-                let writer = ::timely::dataflow::operators::capture::EventWriter::new(stream);
-                let mut logger = ::timely::logging::BatchLogger::new(writer);
-                worker.log_register().unwrap().insert::<DifferentialEventBuilder,_>("differential/arrange", move |time, data|
-                    logger.publish_batch(time, data)
-                );
-            }
-            else {
-                panic!("Could not connect to differential log address: {:?}", addr);
-            }
-        }
-
         let timer = ::std::time::Instant::now();
 
         // define BFS dataflow; return handles to roots and edges inputs

differential-dataflow/src/operators/reduce.rs

@@ -331,6 +331,7 @@ where
         let result_trace = &mut result_trace;
         trace.stream.unary_frontier(Pipeline, name, move |_capability, operator_info| {
 
+            // Acquire a logger for arrange events.
             let logger = trace.stream.scope().logger_for::<crate::logging::DifferentialEventBuilder>("differential/arrange").map(Into::into);
 
             let activator = Some(trace.stream.scope().activator_for(operator_info.address.clone()));