Add clippy lints

Adds a variety of clippy lints such that it doesn't interfere more than
necessary with the current code style.

Does not enable `shadow_unrelated` yet.

Signed-off-by: Moritz Hoffmann <[email protected]>

Author: antiguru

.github/workflows/test.yml

@@ -5,6 +5,10 @@ on:
       - master
   pull_request:
 
+# Make sure CI fails on all warnings, including Clippy lints
+env:
+  RUSTFLAGS: "-Dwarnings"
+
 jobs:
   test:
     strategy:
@@ -25,6 +29,8 @@ jobs:
           toolchain: ${{ matrix.toolchain }}
       - name: Cargo test
         run: cargo test --workspace --all-targets
+      - name: Cargo clippy
+        run: cargo clippy --workspace --all-targets
 
   # Check mdbook files for errors
   mdbook:

Cargo.toml

@@ -15,6 +15,70 @@ edition = "2021"
 [workspace.dependencies]
 columnar = "0.3"
 
+[workspace.lints.clippy]
+type_complexity = "allow"
+option_map_unit_fn = "allow"
+wrong_self_convention = "allow"
+should_implement_trait = "allow"
+module_inception = "allow"
+
+#as_conversions = "warn"
+bool_comparison = "warn"
+borrow_interior_mutable_const = "warn"
+borrowed_box = "warn"
+builtin_type_shadow = "warn"
+clone_on_ref_ptr = "warn"
+crosspointer_transmute = "warn"
+dbg_macro = "warn"
+deref_addrof = "warn"
+disallowed_macros = "warn"
+disallowed_methods = "warn"
+disallowed_types = "warn"
+double_must_use = "warn"
+double_neg = "warn"
+double_parens = "warn"
+duplicate_underscore_argument = "warn"
+excessive_precision = "warn"
+extra_unused_lifetimes = "warn"
+from_over_into = "warn"
+match_overlapping_arm = "warn"
+must_use_unit = "warn"
+mut_mutex_lock = "warn"
+needless_borrow = "warn"
+needless_pass_by_ref_mut = "warn"
+needless_question_mark = "warn"
+needless_return = "warn"
+no_effect = "warn"
+panicking_overflow_checks = "warn"
+partialeq_ne_impl = "warn"
+print_literal = "warn"
+redundant_closure = "warn"
+redundant_closure_call = "warn"
+redundant_field_names = "warn"
+redundant_pattern = "warn"
+redundant_slicing = "warn"
+redundant_static_lifetimes = "warn"
+same_item_push = "warn"
+#shadow_unrelated = "warn"
+single_component_path_imports = "warn"
+suspicious_assignment_formatting = "warn"
+suspicious_else_formatting = "warn"
+suspicious_unary_op_formatting = "warn"
+todo = "warn"
+transmutes_expressible_as_ptr_casts = "warn"
+unnecessary_cast = "warn"
+unnecessary_lazy_evaluations = "warn"
+unnecessary_mut_passed = "warn"
+unnecessary_unwrap = "warn"
+unused_async = "warn"
+useless_asref = "warn"
+useless_conversion = "warn"
+useless_format = "warn"
+wildcard_in_or_patterns = "warn"
+write_literal = "warn"
+zero_divided_by_zero = "warn"
+zero_prefixed_literal = "warn"
+
 [profile.release]
 opt-level = 3
 debug = true

bytes/Cargo.toml

@@ -11,3 +11,6 @@ homepage = "https://github.com/TimelyDataflow/timely-dataflow"
 repository = "https://github.com/TimelyDataflow/timely-dataflow.git"
 keywords = ["timely", "dataflow", "bytes"]
 license = "MIT"
+
+[lints]
+workspace = true

bytes/src/lib.rs

@@ -94,7 +94,7 @@ pub mod arc {
             let result = BytesMut {
                 ptr: self.ptr,
                 len: index,
-                sequestered: self.sequestered.clone(),
+                sequestered: Arc::clone(&self.sequestered),
             };
 
             self.ptr = self.ptr.wrapping_add(index);
@@ -204,7 +204,7 @@ pub mod arc {
             let result = Bytes {
                 ptr: self.ptr,
                 len: index,
-                sequestered: self.sequestered.clone(),
+                sequestered: Arc::clone(&self.sequestered),
             };
 
             self.ptr = self.ptr.wrapping_add(index);

communication/Cargo.toml

@@ -13,6 +13,9 @@ repository = "https://github.com/TimelyDataflow/timely-dataflow.git"
 keywords = ["timely", "dataflow"]
 license = "MIT"
 
+[lints]
+workspace = true
+
 [features]
 default = ["getopts"]
 

communication/examples/comm_hello.rs

@@ -32,9 +32,9 @@ fn main() {
         let (mut senders, mut receiver) = allocator.allocate(0);
 
         // send typed data along each channel
-        for i in 0 .. allocator.peers() {
-            senders[i].send(Message { payload: format!("hello, {}", i)});
-            senders[i].done();
+        for (i, sender) in senders.iter_mut().enumerate() {
+            sender.send(Message { payload: format!("hello, {}", i)});
+            sender.done();
         }
 
         // no support for termination notification,

communication/examples/lgalloc.rs

@@ -59,9 +59,9 @@ impl Drop for LgallocHandle {
 }
 
 fn main() {
-    let mut config = lgalloc::LgAlloc::new();
-    config.enable().with_path(std::env::temp_dir()); 
-    lgalloc::lgalloc_set_config(&config);
+    let mut lgconfig = lgalloc::LgAlloc::new();
+    lgconfig.enable().with_path(std::env::temp_dir());
+    lgalloc::lgalloc_set_config(&lgconfig);
 
     let refill = BytesRefill {
         logic: std::sync::Arc::new(|size| lgalloc_refill(size) as Box<dyn DerefMut<Target=[u8]>>),
@@ -79,9 +79,9 @@ fn main() {
         let (mut senders, mut receiver) = allocator.allocate(0);
 
         // send typed data along each channel
-        for i in 0 .. allocator.peers() {
-            senders[i].send(Message { payload: format!("hello, {}", i)});
-            senders[i].done();
+        for (i, sender) in senders.iter_mut().enumerate() {
+            sender.send(Message { payload: format!("hello, {}", i)});
+            sender.done();
         }
 
         // no support for termination notification,

communication/src/allocator/mod.rs

@@ -94,7 +94,7 @@ pub trait Allocate {
         (thread::ThreadPusher<T>,
          thread::ThreadPuller<T>)
     {
-        thread::Thread::new_from(identifier, self.events().clone())
+        thread::Thread::new_from(identifier, Rc::clone(self.events()))
     }
 
     /// Allocates a broadcast channel, where each pushed message is received by all.

communication/src/allocator/process.rs

@@ -102,7 +102,7 @@ impl PeerBuilder for Process {
                     peers,
                     buzzers_send: bsend,
                     buzzers_recv: brecv,
-                    channels: channels.clone(),
+                    channels: Arc::clone(&channels),
                     counters_send: counters_send.clone(),
                     counters_recv: recv,
                 }
@@ -173,7 +173,7 @@ impl Allocate for Process {
              .map(|s| Box::new(s) as Box<dyn Push<T>>)
              .collect::<Vec<_>>();
 
-        let recv = Box::new(CountPuller::new(recv, identifier, self.inner.events().clone())) as Box<dyn Pull<T>>;
+        let recv = Box::new(CountPuller::new(recv, identifier, Rc::clone(self.inner.events()))) as Box<dyn Pull<T>>;
 
         (sends, recv)
     }

communication/src/allocator/thread.rs

@@ -30,7 +30,7 @@ impl Allocate for Thread {
     fn index(&self) -> usize { 0 }
     fn peers(&self) -> usize { 1 }
     fn allocate<T: 'static>(&mut self, identifier: usize) -> (Vec<Box<dyn Push<T>>>, Box<dyn Pull<T>>) {
-        let (pusher, puller) = Thread::new_from(identifier, self.events.clone());
+        let (pusher, puller) = Thread::new_from(identifier, Rc::clone(&self.events));
         (vec![Box::new(pusher)], Box::new(puller))
     }
     fn events(&self) -> &Rc<RefCell<Vec<usize>>> {
@@ -59,8 +59,8 @@ impl Thread {
         -> (ThreadPusher<T>, ThreadPuller<T>)
     {
         let shared = Rc::new(RefCell::new((VecDeque::<T>::new(), VecDeque::<T>::new())));
-        let pusher = Pusher { target: shared.clone() };
-        let pusher = CountPusher::new(pusher, identifier, events.clone());
+        let pusher = Pusher { target: Rc::clone(&shared) };
+        let pusher = CountPusher::new(pusher, identifier, Rc::clone(&events));
         let puller = Puller { source: shared, current: None };
         let puller = CountPuller::new(puller, identifier, events);
         (pusher, puller)