Introduce builder for flatmap operators #704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiguru
reviewed
Aug 28, 2025
| } | ||
| } | ||
| /// Convert the wrapper into a stream. | ||
| pub fn into_stream<C2>(self) -> StreamCore<S, C2> |
Member
There was a problem hiding this comment.
Could S be a parameter on this function?
Member
Author
There was a problem hiding this comment.
Yes, though a bit surprising. You can have an arbitrary &t T and only at this moment require that it implement Map<S, C>. I'll push it up.
frankmcsherry
force-pushed
the
flat_map_builder
branch
from
2fd8fcd to
e59e87b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed this a year back, but I couldn't recall why we didn't move it forward. I copy/pasted the code, and dressed up the documentation and examples. Worth taking a peek!