refactor: use parallel execution to fetch recommendations from tmdb

Author: TimilsinaBimal

app/api/endpoints/catalogs.py

@@ -120,9 +120,6 @@ async def get_catalog(type: str, id: str, response: Response, token: str):
             token=token,
             library_data=library_items,
         )
-        # Custom attribute for modularized exclusion logic if needed
-        # In this refactor, RecommendationFiltering.get_exclusion_sets(stremio_service, library_data)
-        # is called inside engine, and we pass bundle as stremio_service.
 
         # Resolve per-catalog limits (min/max)
         def _get_limits() -> tuple[int, int]:

app/services/recommendation/engine.py

@@ -292,7 +292,6 @@ async def get_recommendations_for_item(self, item_id: str, media_type: str = "mo
 
     async def _fetch_raw_recommendations(self, item_id: str, media_type: str, limit: int) -> list[dict[str, Any]]:
         """Fetch raw recommendations from TMDB (multiple pages)."""
-        # Logic from _fetch_recommendations_from_tmdb
         mtype = "tv" if media_type in ("tv", "series") else "movie"
         tmdb_id = None
 
@@ -313,25 +312,21 @@ async def _fetch_raw_recommendations(self, item_id: str, media_type: str, limit:
             return []
 
         combined = {}
-        for p in [1, 2, 3]:
-            res = await self.tmdb_service.get_recommendations(tmdb_id, mtype, page=p)
-            for it in res.get("results", []):
-                if it.get("id"):
-                    combined[it["id"]] = it
-            if len(combined) >= limit:
-                break
+        # fetch two pages of data
+        for action in ["recommendations", "similar"]:
+            method = getattr(self.tmdb_service, f"get_{action}")
+            results = await asyncio.gather(*[method(tmdb_id, mtype, page=p) for p in [1, 2]], return_exceptions=True)
+
+            for res in results:
+                if isinstance(res, Exception):
+                    logger.error(f"Error fetching {action} for {tmdb_id}: {res}")
+                    continue
+                for it in res.get("results", []):
+                    if it.get("id"):
+                        combined[it["id"]] = it
 
-        if len(combined) < max(20, limit // 2):
-            try:
-                for p in [1, 2]:
-                    res = await self.tmdb_service.get_similar(tmdb_id, mtype, page=p)
-                    for it in res.get("results", []):
-                        if it.get("id"):
-                            combined[it["id"]] = it
-                    if len(combined) >= limit:
-                        break
-            except Exception:
-                pass
+            if len(combined) >= max(20, limit // 2):
+                break
 
         return list(combined.values())
 

app/services/recommendation/filtering.py

@@ -45,7 +45,11 @@ async def get_exclusion_sets(
                 return set(), set()
             library_data = await stremio_service.library.get_library_items(auth_key)
 
-        all_items = library_data.get("loved", []) + library_data.get("watched", []) + library_data.get("removed", [])
+        all_items = (
+            library_data.get("loved", [])
+            + library_data.get("watched", [])
+            + library_data.get("removed", [] + library_data.get("liked"))
+        )
 
         imdb_ids = set()
         tmdb_ids = set()