cargo: Bump rustc to 1.89 (servo#36818)

Update Rustc to 1.89.

Reviewable by commit.

Leftover work:
- servo#37330 
- servo#38777

---------

Signed-off-by: sagudev <[email protected]>
Co-authored-by: sagudev <[email protected]>

Author: webbeef

components/canvas/raqote_backend.rs

@@ -135,7 +135,7 @@ impl Repetition {
     }
 }
 
-pub fn source(pattern: &Pattern) -> raqote::Source {
+pub fn source(pattern: &Pattern) -> raqote::Source<'_> {
     match pattern {
         Pattern::Color(a, r, g, b) => raqote::Source::Solid(
             raqote::SolidSource::from_unpremultiplied_argb(*a, *r, *g, *b),

components/compositing/compositor.rs

@@ -1376,7 +1376,7 @@ impl IOCompositor {
     }
 
     /// Get the message receiver for this [`IOCompositor`].
-    pub fn receiver(&self) -> Ref<Receiver<CompositorMsg>> {
+    pub fn receiver(&self) -> Ref<'_, Receiver<CompositorMsg>> {
         Ref::map(self.global.borrow(), |global| &global.compositor_receiver)
     }
 

components/compositing/webview_renderer.rs

@@ -187,7 +187,7 @@ impl WebViewRenderer {
 
     pub(crate) fn set_frame_tree(&mut self, frame_tree: &SendableFrameTree) {
         let pipeline_id = frame_tree.pipeline.id;
-        let old_pipeline_id = std::mem::replace(&mut self.root_pipeline_id, Some(pipeline_id));
+        let old_pipeline_id = self.root_pipeline_id.replace(pipeline_id);
 
         if old_pipeline_id != self.root_pipeline_id {
             debug!(

components/constellation/constellation.rs

@@ -1019,7 +1019,7 @@ where
     fn fully_active_descendant_browsing_contexts_iter(
         &self,
         browsing_context_id: BrowsingContextId,
-    ) -> FullyActiveBrowsingContextsIterator {
+    ) -> FullyActiveBrowsingContextsIterator<'_> {
         FullyActiveBrowsingContextsIterator {
             stack: vec![browsing_context_id],
             pipelines: &self.pipelines,
@@ -1031,15 +1031,15 @@ where
     fn fully_active_browsing_contexts_iter(
         &self,
         webview_id: WebViewId,
-    ) -> FullyActiveBrowsingContextsIterator {
+    ) -> FullyActiveBrowsingContextsIterator<'_> {
         self.fully_active_descendant_browsing_contexts_iter(BrowsingContextId::from(webview_id))
     }
 
     /// Get an iterator for the browsing contexts in a subtree.
     fn all_descendant_browsing_contexts_iter(
         &self,
         browsing_context_id: BrowsingContextId,
-    ) -> AllBrowsingContextsIterator {
+    ) -> AllBrowsingContextsIterator<'_> {
         AllBrowsingContextsIterator {
             stack: vec![browsing_context_id],
             pipelines: &self.pipelines,
@@ -1157,6 +1157,7 @@ where
     /// Handles loading pages, navigation, and granting access to the compositor
     #[servo_tracing::instrument(skip_all)]
     fn handle_request(&mut self) {
+        #[allow(clippy::large_enum_variant)]
         #[derive(Debug)]
         enum Request {
             PipelineNamespace(PipelineNamespaceRequest),
@@ -3174,16 +3175,16 @@ where
                     );
                 },
             };
-            let is_parent_private = match self.browsing_contexts.get(&parent_browsing_context_id) {
+
+            match self.browsing_contexts.get(&parent_browsing_context_id) {
                 Some(ctx) => ctx.is_private,
                 None => {
                     return warn!(
                         "{}: Script loaded url in iframe {} in closed parent browsing context",
                         parent_browsing_context_id, browsing_context_id,
                     );
                 },
-            };
-            is_parent_private
+            }
         };
         let is_private = is_private || is_parent_private;
 

components/devtools/actors/inspector/page_style.rs

@@ -175,42 +175,41 @@ impl PageStyleActor {
 
             // For each selector (plus an empty one that represents the style attribute)
             // get all of the rules associated with it.
-            let entries =
-                once(("".into(), usize::MAX))
-                    .chain(selectors)
-                    .filter_map(move |selector| {
-                        let rule = match node_actor.style_rules.borrow_mut().entry(selector) {
-                            Entry::Vacant(e) => {
-                                let name = registry.new_name("style-rule");
-                                let actor = StyleRuleActor::new(
-                                    name.clone(),
-                                    node_actor.name(),
-                                    (!e.key().0.is_empty()).then_some(e.key().clone()),
-                                );
-                                let rule = actor.applied(registry)?;
 
-                                registry.register_later(Box::new(actor));
-                                e.insert(name);
-                                rule
-                            },
-                            Entry::Occupied(e) => {
-                                let actor = registry.find::<StyleRuleActor>(e.get());
-                                actor.applied(registry)?
-                            },
-                        };
-                        if inherited.is_some() && rule.declarations.is_empty() {
-                            return None;
-                        }
+            once(("".into(), usize::MAX))
+                .chain(selectors)
+                .filter_map(move |selector| {
+                    let rule = match node_actor.style_rules.borrow_mut().entry(selector) {
+                        Entry::Vacant(e) => {
+                            let name = registry.new_name("style-rule");
+                            let actor = StyleRuleActor::new(
+                                name.clone(),
+                                node_actor.name(),
+                                (!e.key().0.is_empty()).then_some(e.key().clone()),
+                            );
+                            let rule = actor.applied(registry)?;
 
-                        Some(AppliedEntry {
-                            rule,
-                            // TODO: Handle pseudo elements
-                            pseudo_element: None,
-                            is_system: false,
-                            inherited: inherited.clone(),
-                        })
-                    });
-            entries
+                            registry.register_later(Box::new(actor));
+                            e.insert(name);
+                            rule
+                        },
+                        Entry::Occupied(e) => {
+                            let actor = registry.find::<StyleRuleActor>(e.get());
+                            actor.applied(registry)?
+                        },
+                    };
+                    if inherited.is_some() && rule.declarations.is_empty() {
+                        return None;
+                    }
+
+                    Some(AppliedEntry {
+                        rule,
+                        // TODO: Handle pseudo elements
+                        pseudo_element: None,
+                        is_system: false,
+                        inherited: inherited.clone(),
+                    })
+                })
         })
         .collect();
         let msg = GetAppliedReply {

components/fonts/font_context.rs

@@ -320,7 +320,7 @@ impl FontContext {
                 font_key
             });
 
-        let key = *self
+        *self
             .webrender_font_instance_keys
             .write()
             .entry((font_key, pt_size, variations.clone()))
@@ -334,8 +334,7 @@ impl FontContext {
                     variations,
                 );
                 font_instance_key
-            });
-        key
+            })
     }
 
     fn invalidate_font_groups_after_web_font_load(&self) {

components/fonts/glyph.rs

@@ -606,7 +606,7 @@ impl GlyphStore {
     pub fn iter_glyphs_for_byte_range(
         &self,
         range: &Range<ByteIndex>,
-    ) -> impl Iterator<Item = GlyphInfo> + use<'_> {
+    ) -> impl Iterator<Item = GlyphInfo<'_>> + use<'_> {
         if range.begin() >= self.len() {
             panic!("iter_glyphs_for_range: range.begin beyond length!");
         }

components/hyper_serde/lib.rs

@@ -431,6 +431,10 @@ impl Serialize for Ser<'_, HeaderMap> {
             {
                 let mut serializer = serializer.serialize_seq(Some(self.0.len()))?;
                 for v in self.0 {
+                    #[allow(
+                        clippy::collapsible_if,
+                        reason = "let chains are not available in 1.85"
+                    )]
                     if self.1 {
                         if let Ok(v) = str::from_utf8(v) {
                             serializer.serialize_element(v)?;

components/layout/flexbox/layout.rs

@@ -1001,7 +1001,7 @@ impl FlexContainer {
     }
 
     #[inline]
-    pub(crate) fn layout_style(&self) -> LayoutStyle {
+    pub(crate) fn layout_style(&self) -> LayoutStyle<'_> {
         LayoutStyle::Default(&self.style)
     }
 }
@@ -2046,7 +2046,7 @@ impl FlexItemBox {
         content_box_sizes_and_pbm: &ContentBoxSizesAndPBM,
         config: &FlexContainerConfig,
         flex_context_getter: &impl Fn() -> &'a FlexContext<'a>,
-    ) -> FlexItem {
+    ) -> FlexItem<'_> {
         let flex_axis = config.flex_axis;
         let style = self.style();
         let cross_axis_is_item_block_axis = cross_axis_is_item_block_axis(

components/layout/flexbox/mod.rs

@@ -151,6 +151,7 @@ impl FlexContainer {
     }
 }
 
+#[allow(clippy::large_enum_variant)]
 #[derive(Debug, MallocSizeOf)]
 pub(crate) enum FlexLevelBox {
     FlexItem(FlexItemBox),