Skip to content

Commit 734de36

Browse files
Add coverage for incompatible flags (#306)
* Add coverage for incompatible flags We need coverage over this to get into the BCR now * more updates * more updates * more coverage * read order * test * more updates * regen
1 parent 53c5b0a commit 734de36

File tree

6 files changed

+139
-423
lines changed

6 files changed

+139
-423
lines changed

.github/workflows/ci.yaml

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,24 @@ jobs:
4242
test-jre11-run-example:
4343
runs-on: ubuntu-latest
4444
strategy:
45+
fail-fast: false
4546
matrix:
46-
bazel: ['7.x', '8.x', '8.6.0rc1']
47+
include:
48+
- bazel: '7.x'
49+
disable_workspace: 'false'
50+
extra_flags: ''
51+
- bazel: '7.x'
52+
disable_workspace: 'false'
53+
extra_flags: '--incompatible_disable_native_repo_rules'
54+
- bazel: '8.x'
55+
disable_workspace: 'true'
56+
extra_flags: ''
57+
- bazel: '8.6.0rc1'
58+
disable_workspace: 'true'
59+
extra_flags: ''
60+
- bazel: '8.x'
61+
disable_workspace: 'true'
62+
extra_flags: '--incompatible_disable_native_repo_rules'
4763
steps:
4864
- name: Setup Java JDK
4965
uses: actions/setup-java@v4
@@ -64,8 +80,9 @@ jobs:
6480
- name: Run bazel-diff example script
6581
env:
6682
USE_BAZEL_VERSION: ${{ matrix.bazel }}
67-
BAZEL_DIFF_DISABLE_WORKSPACE: ${{ matrix.bazel == '8.x' && 'true' || 'false' }}
83+
BAZEL_DIFF_DISABLE_WORKSPACE: ${{ matrix.disable_workspace }}
6884
BAZEL_DIFF_FORCE_CHECKOUT: true
85+
BAZEL_EXTRA_COMMAND_OPTIONS: ${{ matrix.extra_flags }}
6986
run: ./bazel-diff-example.sh "$GITHUB_WORKSPACE" ~/go/bin/bazelisk $(git rev-parse HEAD~1) $(git rev-parse HEAD)
7087
deploy:
7188
needs: [test-jre21]

MODULE.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ module(
66

77
bazel_dep(name = "rules_license", version = "1.0.0", dev_dependency = True)
88
bazel_dep(name = "aspect_rules_lint", version = "1.0.2", dev_dependency = True)
9+
bazel_dep(name = "aspect_bazel_lib", version = "2.22.5", dev_dependency = True)
910

10-
bazel_dep(name = "aspect_bazel_lib", version = "2.7.7")
11-
bazel_dep(name = "bazel_skylib", version = "1.7.1")
11+
bazel_dep(name = "bazel_skylib", version = "1.8.1")
1212
bazel_dep(name = "rules_proto", version = "7.1.0")
1313
bazel_dep(name = "rules_java", version = "8.14.0")
1414
bazel_dep(name = "rules_kotlin", version = "2.1.3")

0 commit comments

Comments
 (0)