Skip to content

Commit 621a857

Browse files
authored
✅ Add test to reset logger filters. (#827)
- Logger filters need to be reset at the start of run. This is required if a failed test with logs is run in another pytest. - This PR fixes [failed tests](https://github.com/TissueImageAnalytics/tiatoolbox/actions/runs/9414105193/job/25932262521) in #783.
1 parent 73aa802 commit 621a857

File tree

2 files changed

+17
-0
lines changed

2 files changed

+17
-0
lines changed

tests/test_annotation_stores.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
Polygon,
2828
)
2929

30+
from tiatoolbox import logger
3031
from tiatoolbox.annotation import (
3132
Annotation,
3233
AnnotationStore,
@@ -52,6 +53,14 @@
5253
FILLED_LEN = 2 * (GRID_SIZE[0] * GRID_SIZE[1])
5354
RNG = np.random.default_rng(0) # Numpy Random Generator
5455

56+
# ----------------------------------------------------------------------
57+
# Resets
58+
# ----------------------------------------------------------------------
59+
60+
# Reset filters in logger.
61+
for filter_ in logger.filters:
62+
logger.removeFilter(filter_)
63+
5564
# ----------------------------------------------------------------------
5665
# Helper Functions
5766
# ----------------------------------------------------------------------

tests/test_init.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,14 @@ def test_logger_output() -> None:
109109

110110
def test_duplicate_filter(caplog: pytest.LogCaptureFixture) -> None:
111111
"""Test DuplicateFilter for warnings."""
112+
# Test logger reset after applying duplicate filter.
113+
duplicate_filter = DuplicateFilter()
114+
logger.addFilter(duplicate_filter)
115+
116+
# Reset filters in logger.
117+
for filter_ in logger.filters:
118+
logger.removeFilter(filter_)
119+
112120
for _ in range(2):
113121
logger.warning("Test duplicate filter warnings.")
114122
assert "Test duplicate filter warnings." in caplog.text

0 commit comments

Comments
 (0)