💡 Address @Copilot comments

Author: shaneahmed

tests/models/test_dataset.py

@@ -540,3 +540,23 @@ def __getitem__(self: Proto, idx: int) -> None:
     # test assign uncallable to preproc_func/postproc_func
     with pytest.raises(ValueError, match=r".*callable*"):
         ds.preproc_func = 1  # skipcq: PYL-W0201
+
+
+def test_none_patch_input_shape(sample_svs: Path) -> None:
+    """Test for None patch input shape."""
+    with pytest.raises(ValueError, match=r".*`patch_input_shape` must be specified.*"):
+        WSIPatchDataset(
+            img_path=sample_svs,
+            stride_shape=(256, 256),
+            auto_get_mask=False,
+        )
+
+
+def test_none_stride_shape_shape(sample_svs: Path) -> None:
+    """Test for None stride shape."""
+    with pytest.raises(ValueError, match=r".*`stride_shape` must be specified.*"):
+        WSIPatchDataset(
+            img_path=sample_svs,
+            patch_input_shape=(256, 256),
+            auto_get_mask=False,
+        )

tiatoolbox/models/engine/engine_abc.py

@@ -1010,7 +1010,7 @@ def _update_run_params(
         for key in kwargs:
             setattr(self, key, kwargs.get(key))
 
-        if self.num_workers is not None and self.num_workers > 0:
+        if self.num_workers > 0:
             dask.config.set(scheduler="threads", num_workers=self.num_workers)
         else:
             dask.config.set(scheduler="threads")

tiatoolbox/models/engine/semantic_segmentor.py

@@ -436,7 +436,7 @@ def infer_wsi(
         tqdm_loop = (
             tqdm(dataloader, leave=False, desc="Inferring patches")
             if self.verbose
-            else self.dataloader
+            else dataloader
         )
 
         canvas_np, output_locs_y_ = None, None