Clean up excessive logging (#21)

Author: TitanNano

rust-script/src/runtime/rust_script.rs

@@ -93,17 +93,10 @@ impl RustScript {
     fn owner_ids(&self) -> Array<i64> {
         let owners = self.owners.borrow();
 
-        godot_print!("extracting script owners: {:?}", *owners);
-
         let set: HashSet<_> = owners
             .iter()
-            .filter_map(|item| {
-                let strong_ref = item.get_ref().to::<Option<Gd<Object>>>();
-
-                godot_print!("strong ref: {:?}", strong_ref);
-
-                strong_ref.map(|obj| obj.instance_id().to_i64())
-            })
+            .filter_map(|item| item.get_ref().to::<Option<Gd<Object>>>())
+            .map(|obj| obj.instance_id().to_i64())
             .collect();
 
         set.into_iter().collect()
@@ -120,21 +113,11 @@ impl RustScript {
             godot_warn!("over writing existing owners of rust script");
         }
 
-        godot_print!("assigning owners list to script: {:?}", ids);
-
         *self.owners.borrow_mut() = ids
             .iter_shared()
             .map(InstanceId::from_i64)
             .filter_map(|id| {
-                godot_print!(
-                    "reloading script instance of {}, {}",
-                    id,
-                    self.get_class_name()
-                );
-
                 let result: Option<Gd<Object>> = Gd::try_from_instance_id(id).ok();
-
-                godot_print!("object for {} is {:?}", id, result);
                 result
             })
             .map(|gd_ref| godot::engine::utilities::weakref(gd_ref.to_variant()).to())
@@ -145,8 +128,6 @@ impl RustScript {
 #[godot_api]
 impl IScriptExtension for RustScript {
     fn init(base: Base<Self::Base>) -> Self {
-        godot_print!("creating RustScript struct for {:?}", base);
-
         Self {
             class_name: GString::new(),
             source_code: GString::new(),
@@ -203,11 +184,6 @@ impl IScriptExtension for RustScript {
     }
 
     unsafe fn placeholder_instance_create(&self, for_object: Gd<Object>) -> *mut c_void {
-        godot_print!(
-            "creating placeholder instance for script {}",
-            self.get_global_name()
-        );
-
         self.owners
             .borrow_mut()
             .push(godot::engine::utilities::weakref(for_object.to_variant()).to());
@@ -347,11 +323,6 @@ impl IScriptExtension for RustScript {
 
     // godot script reload hook
     fn reload(&mut self, _keep_state: bool) -> godot::engine::global::Error {
-        godot_print!(
-            "new script properties: {:?}",
-            self.get_script_property_list()
-        );
-
         self.owners.borrow().iter().for_each(|owner| {
             let mut object: Gd<Object> = match owner.get_ref().try_to() {
                 Ok(owner) => owner,

rust-script/src/runtime/rust_script_instance.rs

@@ -13,7 +13,6 @@ use godot::{
     engine::{Script, ScriptInstance},
     obj::UserClass,
     prelude::{
-        godot_print,
         meta::{MethodInfo, PropertyInfo},
         GString, Gd, Object, StringName, Variant, VariantType,
     },
@@ -144,7 +143,6 @@ impl ScriptInstance for RustScriptInstance {
         method: StringName,
         args: &[&Variant],
     ) -> Result<Variant, godot::sys::GDExtensionCallErrorType> {
-        godot_print!("calling {}::{}", self.class_name(), method);
         let method =
             RString::with_capacity(method.len()).apply(|s| s.push_str(&method.to_string()));
         let rargs = args.iter().map(|v| RemoteValueRef::new(v)).collect();
@@ -268,7 +266,7 @@ impl ScriptInstance for RustScriptPlaceholder {
         _method: StringName,
         _args: &[&Variant],
     ) -> Result<Variant, godot::sys::GDExtensionCallErrorType> {
-        Err(godot::sys::GDEXTENSION_CALL_OK)
+        Err(godot::sys::GDEXTENSION_CALL_ERROR_INVALID_METHOD)
     }
 
     fn get_script(&self) -> &Gd<Script> {

rust-script/src/script_registry.rs

@@ -15,7 +15,6 @@ use godot::{
     engine::global::{MethodFlags, PropertyHint, PropertyUsageFlags},
     obj::{EngineBitfield, EngineEnum},
     prelude::{
-        godot_print,
         meta::{ClassName, MethodInfo, PropertyInfo},
         Gd, Object, StringName, Variant,
     },
@@ -36,12 +35,6 @@ where
     T: GodotScript,
 {
     fn set(&mut self, name: RString, value: RemoteValueRef) -> bool {
-        godot_print!(
-            "RemoteGodotScript received set_func for \"{}\": {:?}",
-            name,
-            value
-        );
-
         self.set(StringName::from(name.as_str()), value.as_ref().to())
     }