Properly handle calls with invalid arguments (#23)

TitanNano · web-flow · commit a2a5c018fcf0 · 2024-01-05T09:50:05.000+01:00
diff --git a/derive/src/impl_attribute.rs b/derive/src/impl_attribute.rs
@@ -71,9 +71,12 @@ pub fn godot_script_impl(
 
                         quote_spanned! {
                             arg.span() =>
-                            #godot_types::prelude::FromGodot::from_variant(
+                            #godot_types::prelude::FromGodot::try_from_variant(
                                 args.get(#index).ok_or(#godot_types::sys::GDEXTENSION_CALL_ERROR_TOO_FEW_ARGUMENTS)?
-                            )
+                            ).map_err(|err| {
+                                #godot_types::log::godot_error!("failed to convert variant: {}", err);
+                                #godot_types::sys::GDEXTENSION_CALL_ERROR_INVALID_ARGUMENT
+                            })?
                         }
                     )
                 })

Original file line number	Diff line number	Diff line change
`@@ -71,9 +71,12 @@ pub fn godot_script_impl(`
`71`	`71`
`72`	`72`	`quote_spanned! {`
`73`	`73`	`arg.span() =>`
`74`		`- #godot_types::prelude::FromGodot::from_variant(`
	`74`	`+ #godot_types::prelude::FromGodot::try_from_variant(`
`75`	`75`	`args.get(#index).ok_or(#godot_types::sys::GDEXTENSION_CALL_ERROR_TOO_FEW_ARGUMENTS)?`
`76`		`- )`
	`76`	`+ ).map_err(\|err\| {`
	`77`	`+ #godot_types::log::godot_error!("failed to convert variant: {}", err);`
	`78`	`+ #godot_types::sys::GDEXTENSION_CALL_ERROR_INVALID_ARGUMENT`
	`79`	`+ })?`
`77`	`80`	`}`
`78`	`81`	`)`
`79`	`82`	`})`