Skip to content

Commit 2572475

Browse files
fixed code quality
1 parent eda3d7b commit 2572475

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

rest_auth/registration/views.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424
from rest_auth.utils import jwt_encode
2525

26+
2627
class RegisterView(CreateAPIView):
2728
serializer_class = RegisterSerializer
2829
permission_classes = (AllowAny, )

rest_auth/serializers.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ class Meta:
118118
model = TokenModel
119119
fields = ('key',)
120120

121+
121122
class UserDetailsSerializer(serializers.ModelSerializer):
122123

123124
"""
@@ -128,13 +129,15 @@ class Meta:
128129
fields = ('username', 'email', 'first_name', 'last_name')
129130
read_only_fields = ('email', )
130131

132+
131133
class JWTSerializer(serializers.Serializer):
132134
"""
133135
Serializer for JWT authentication.
134136
"""
135137
token = serializers.CharField()
136138
user = UserDetailsSerializer()
137139

140+
138141
class PasswordResetSerializer(serializers.Serializer):
139142

140143
"""

rest_auth/tests/test_api.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -97,13 +97,12 @@ def test_login_jwt(self):
9797
"username": self.USERNAME,
9898
"password": self.PASS
9999
}
100-
user = get_user_model().objects.create_user(self.USERNAME, '', self.PASS)
100+
get_user_model().objects.create_user(self.USERNAME, '', self.PASS)
101101

102102
self.post(self.login_url, data=payload, status_code=200)
103103
self.assertEqual('token' in self.response.json.keys(), True)
104104
self.token = self.response.json['token']
105105

106-
107106
def test_login_by_email(self):
108107
# starting test without allauth app
109108
settings.INSTALLED_APPS.remove('allauth')
@@ -335,7 +334,6 @@ def test_user_details_using_jwt(self):
335334
user = get_user_model().objects.get(pk=user.pk)
336335
self.assertEqual(user.email, self.response.json['email'])
337336

338-
339337
def test_registration(self):
340338
user_count = get_user_model().objects.all().count()
341339

@@ -365,7 +363,6 @@ def test_registration_with_jwt(self):
365363
self._login()
366364
self._logout()
367365

368-
369366
def test_registration_with_invalid_password(self):
370367
data = self.REGISTRATION_DATA.copy()
371368
data['password2'] = 'foobar'
@@ -430,7 +427,7 @@ def test_logout_on_get(self):
430427
}
431428

432429
# create user
433-
user = get_user_model().objects.create_user(self.USERNAME, '', self.PASS)
430+
get_user_model().objects.create_user(self.USERNAME, '', self.PASS)
434431

435432
self.post(self.login_url, data=payload, status_code=200)
436433
self.get(self.logout_url, status=status.HTTP_200_OK)
@@ -443,7 +440,7 @@ def test_logout_on_post_only(self):
443440
}
444441

445442
# create user
446-
user = get_user_model().objects.create_user(self.USERNAME, '', self.PASS)
443+
get_user_model().objects.create_user(self.USERNAME, '', self.PASS)
447444

448445
self.post(self.login_url, data=payload, status_code=status.HTTP_200_OK)
449446
self.get(self.logout_url, status_code=status.HTTP_405_METHOD_NOT_ALLOWED)

rest_auth/tests/test_social.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,5 @@ def test_jwt(self):
148148
self.post(self.fb_login_url, data=payload, status_code=200)
149149
self.assertIn('token', self.response.json.keys())
150150
self.assertIn('user', self.response.json.keys())
151-
152-
self.assertEqual(get_user_model().objects.all().count(), users_count + 1)
153151

152+
self.assertEqual(get_user_model().objects.all().count(), users_count + 1)

rest_auth/utils.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,9 @@ def default_create_token(token_model, user, serializer):
1515
token, _ = token_model.objects.get_or_create(user=user)
1616
return token
1717

18+
1819
def jwt_encode(user):
19-
try:
20+
try:
2021
from rest_framework_jwt.settings import api_settings
2122
except ImportError:
2223
raise ImportError('rest_framework_jwt needs to be installed')

rest_auth/views.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def get_response_serializer(self):
4646

4747
def login(self):
4848
self.user = self.serializer.validated_data['user']
49-
49+
5050
if getattr(settings, 'REST_USE_JWT', False):
5151
self.token = jwt_encode(self.user)
5252
else:
@@ -55,7 +55,6 @@ def login(self):
5555
if getattr(settings, 'REST_SESSION_LOGIN', True):
5656
login(self.request, self.user)
5757

58-
5958
def get_response(self):
6059
serializer_class = self.get_response_serializer()
6160

0 commit comments

Comments
 (0)