Skip to content

Commit 52283ae

Browse files
committed
Merge pull request #129 from ron8mcr/master
raise_exception=True for views
2 parents d90717e + fac959e commit 52283ae

File tree

1 file changed

+4
-18
lines changed

1 file changed

+4
-18
lines changed

rest_auth/views.py

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,9 @@ def get_response(self):
4444
self.response_serializer(self.token).data, status=status.HTTP_200_OK
4545
)
4646

47-
def get_error_response(self):
48-
return Response(
49-
self.serializer.errors, status=status.HTTP_400_BAD_REQUEST
50-
)
51-
5247
def post(self, request, *args, **kwargs):
5348
self.serializer = self.get_serializer(data=self.request.data)
54-
if not self.serializer.is_valid():
55-
return self.get_error_response()
49+
self.serializer.is_valid(raise_exception=True)
5650
self.login()
5751
return self.get_response()
5852

@@ -112,10 +106,8 @@ class PasswordResetView(GenericAPIView):
112106
def post(self, request, *args, **kwargs):
113107
# Create a serializer with request.data
114108
serializer = self.get_serializer(data=request.data)
109+
serializer.is_valid(raise_exception=True)
115110

116-
if not serializer.is_valid():
117-
return Response(serializer.errors,
118-
status=status.HTTP_400_BAD_REQUEST)
119111
serializer.save()
120112
# Return the success message with OK HTTP status
121113
return Response(
@@ -139,10 +131,7 @@ class PasswordResetConfirmView(GenericAPIView):
139131

140132
def post(self, request):
141133
serializer = self.get_serializer(data=request.data)
142-
if not serializer.is_valid():
143-
return Response(
144-
serializer.errors, status=status.HTTP_400_BAD_REQUEST
145-
)
134+
serializer.is_valid(raise_exception=True)
146135
serializer.save()
147136
return Response({"success": "Password has been reset with the new password."})
148137

@@ -161,9 +150,6 @@ class PasswordChangeView(GenericAPIView):
161150

162151
def post(self, request):
163152
serializer = self.get_serializer(data=request.data)
164-
if not serializer.is_valid():
165-
return Response(
166-
serializer.errors, status=status.HTTP_400_BAD_REQUEST
167-
)
153+
serializer.is_valid(raise_exception=True)
168154
serializer.save()
169155
return Response({"success": "New password has been saved."})

0 commit comments

Comments
 (0)